Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arrow keys not working in Edit Runtime form inputs #1643

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fix arrow keys not working in Edit Runtime form inputs #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
406da59
Fix arrow keys not working in Edit Runtime form inputs
MetRonnie Jan 23, 2024
188d191
Update changelog [skip ci]
MetRonnie Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ creating a new release entry be sure to copy & paste the span tag with the
`actions:bind` attribute, which is used by a regex to find the text to be
updated. Only the first match gets replaced, so it's fine to leave the old
ones in. -->
-------------------------------------------------------------------------------
## __cylc-ui-2.4.0 (<span actions:bind='release-date'>Upcoming</span>)__

### Fixes

[#1643](https://github.com/cylc/cylc-ui/pull/1643) -
Fix bug where the up/down/home/end keys would not work inside the Edit Runtime
form inputs.

-------------------------------------------------------------------------------
## __cylc-ui-2.3.0 (<span actions:bind='release-date'>Released 2023-11-28</span>)__

Expand Down
34 changes: 16 additions & 18 deletions src/components/graphqlFormGenerator/EditRuntimeForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,25 +38,23 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
v-else
v-model="isValid"
ref="form"
class="c-edit-runtime-form"
class="c-edit-runtime-form ma-4"
>
<v-list>
<v-list-item
v-for="key in Object.keys(model)"
:key="key"
>
<v-list-item-title class="c-input-label">
<!-- input label - the display title for this input -->
{{ startCase(key) }}
</v-list-item-title>
<component
:is="getInputProps(key).is"
v-bind="getInputProps(key)"
v-model="model[key]"
:types="types"
/>
</v-list-item>
</v-list>
<div
v-for="key in Object.keys(model)"
:key="key"
>
<v-list-item-title class="c-input-label">
<!-- input label - the display title for this input -->
{{ startCase(key) }}
</v-list-item-title>
<component
:is="getInputProps(key).is"
v-bind="getInputProps(key)"
v-model="model[key]"
:types="types"
/>
</div>
</v-form>
</div>
</template>
Expand Down