-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api-on-the-fly - part 3 - cylc types #382
Conversation
* enums * imput objects * also add some other cylc types
* FormInput should be a configurable interface supporting different compoents * For now just move the config to another file and stick it into the component's data
4dceebe
to
8816e67
Compare
Sorry for the delay on reviewing it. Tomorrow will keep working on the infinite tree, but will try to review either in the afternoon break after lunch, or by Friday 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still had the Cylc Flow branch for the related change, so I re-synced the branch just now, and decided to review this one too.
Didn't check the branch or run any IDE inspection, but from reading the code found nothing wrong. Tested locally with the whole system, and the form was nicely rendered.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested as working
Minor conflicts |
(Fixed conflicts). |
Addresses the "support for custom Cylc types" point in #339
Note - Built atop #359
Note - Works with the data types defined in cylc/cylc-flow#3469
Overview:
Configure Vuetify form components to work with the Cylc data types defined in cylc/cylc-flow#3469.
FormGenerator
(so the component can be reused).Unrelated Changes:
flat
and has some bugs with field outlines)What You Should Expect To See:
BroadcastSettings
).Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.