-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cycle point ID in the tree view structure #505
Conversation
…y-proxy ID. With this we are able to derive the cycle point ID from the family-proxy ID (as the cyclepoint ID is part of it).
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 63.29% 66.38% +3.08%
==========================================
Files 44 43 -1
Lines 970 949 -21
Branches 59 59
==========================================
+ Hits 614 630 +16
+ Misses 338 301 -37
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The The |
@@ -338,16 +340,17 @@ class CylcTree { | |||
// NOTE: when deleting the root family, we can also remove the entire cycle point | |||
if (familyProxyId.endsWith('|root')) { | |||
// 0 has the owner, 1 has the workflow Id, 2 has the cycle point, and 3 the family name | |||
const [owner, workflowId, cyclePoint] = familyProxyId.split('|') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed cyclePoint
as I don't need that, since I'll build the full cycle point ID
…e point ID in the deltas and CylcTree
3f19ffc
to
decfed3
Compare
fragment CyclePointData on FamilyProxy { | ||
id | ||
cyclePoint | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new fragment for cycle points. Notice that it is built from a FamilyProxy
, so effectively the id
is a FamilyProxy
ID
Note to self: look at the offline data and check if we need to re-generate it |
9bcc966
to
644cb3e
Compare
@@ -100,7 +100,4 @@ | |||
# reset stuff | |||
cylc unhold \ | |||
"${CYLC_SUITE_NAME}" "sleepy.${CYLC_TASK_CYCLE_POINT}" | |||
cylc reset \ | |||
"${CYLC_SUITE_NAME}" "retrying.${CYLC_TASK_CYCLE_POINT}" \ | |||
-s 'succeeded' |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Unit tests green. Almost there. I fixed the workflow But now, So my idea now is to write a new query for the offline data, re-using parts of the deltas fragments. But hit a bump with https://github.com/cylc/cylc-uiserver/issues/159 |
Alright, ready for review. @hjoliver is away this week, so happy if any other @cylc/core volunteers to review after @oliver-sanders , or we can wait until next week 👍 |
Added one commit that throws an Tested with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as working 👍
Still needs a change log entry @kinow ?
These changes are related to #504 #339
At the moment every node in the tree has an ID like
kinow|five|1|foo
, except the cycle points, which use just1
(integer-type).I implemented that way as it was the simplest approach, and because our cycle points are built from family proxies in the GraphQL query (cycle points are not types in the schema I think). @oliver-sanders found out that we didn't have the ID's while working on the mutations & api-on-the-fly integration.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.