aotf: toolbar mutate button #598
Conversation
oliver-sanders
force-pushed
the
aotf.toolbar
branch
from
e778396
to
ff5ae3e
Compare
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
- Coverage 82.80% 82.21% -0.59%
==========================================
Files 66 68 +2
Lines 1320 1372 +52
Branches 81 94 +13
==========================================
+ Hits 1093 1128 +35
- Misses 208 222 +14
- Partials 19 22 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| broadcast: mdiBullhorn, | ||
| hold: mdiPause, | ||
| release: mdiPlay, | ||
| kill: mdiCloseCircle, | ||
| message: mdiEmail, | ||
| play: mdiPlay, | ||
| poll: mdiRefreshCircle, | ||
| release: mdiPlay, | ||
| reload: mdiReload, | ||
| remove: mdiDelete, | ||
| setOutputs: mdiGraph, | ||
| stop: mdiStop, | ||
| trigger: mdiCursorPointer |
There was a problem hiding this comment.
Add icons for the workflow-level mutations that didn't show up before.
I guess #135 goes further, with ideas for auto-completion and validating inputs. IMO we should close that issue with this PR, and post another issue for possible enhancements like those... |
|
Closes the first point of #544, the second point is about tracking mutations until they have completed which is something we can't yet do at the backend. |
oliver-sanders
force-pushed
the
aotf.toolbar
branch
from
ff5ae3e
to
badb6a8
Compare
There was a problem hiding this comment.
Working like a charm! Code looks excellent.
@oliver-sanders CHANGES.md has conflicts now. Also, for a follow-up:
I have not submitted this form yet. But apparently the state is kept somewhere I think. So after you submit a mutation once, the form will forever say "submitted", which is a little confusing.
|
(Change log deconflicted via GH UI). |
addresses: #339
built on: #544
related sibling pr: cylc/cylc-uiserver#175
Add a button in the workflow toolbar that lists workflow mutations.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.