-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Yarn v3.0.0-rc2 #653
Changes from all commits
57b26d9
638cb0a
6480ea2
6a9dc5b
f2a9f73
c27a38b
22ec9ff
d09c421
b84df19
c7e312a
3a2eff8
7eb1fb1
22e9b71
24e6f7e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
nodeLinker: node-modules | ||
|
||
yarnPath: .yarn/releases/yarn-3.0.0-rc.2.cjs | ||
|
||
enableNetwork: false | ||
enableStrictSsl: true | ||
|
||
networkSettings: | ||
"registry.yarnpkg.com": | ||
enableNetwork: true | ||
"registry.npmjs.org": | ||
enableNetwork: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
*/ | ||
|
||
module.exports = { | ||
plugins: { | ||
autoprefixer: {} | ||
} | ||
plugins: [ | ||
require('autoprefixer') | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -160,7 +160,7 @@ import TreeItem from '@/components/cylc/tree/TreeItem' | |
import Vue from 'vue' | ||
import TaskState from '@/model/TaskState.model' | ||
import Task from '@/components/cylc/Task' | ||
import clonedeep from 'lodash.clonedeep' | ||
import cloneDeep from 'lodash/cloneDeep' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The first one was using the Our build failed as Yarn is more strict about the transitive dependencies not declared in our Instead of simply adding the new dependency, the change here is using importing the |
||
import { mdiPlus, mdiMinus } from '@mdi/js' | ||
|
||
export default { | ||
|
@@ -254,7 +254,7 @@ export default { | |
this.tasksFilter.states !== null && | ||
this.tasksFilter.states.length > 0 | ||
if (taskNameFilterSet || taskStatesFilterSet) { | ||
this.activeFilters = clonedeep(this.tasksFilter) | ||
this.activeFilters = cloneDeep(this.tasksFilter) | ||
this.filterNodes(this.workflows) | ||
} else { | ||
this.removeAllFilters() | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
@import '../../../node_modules/vuetify/src/styles/styles'; | ||
@import '~vuetify/src/styles/styles'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
$active-color: #BDD5F7; | ||
/** | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -678,7 +678,7 @@ export async function mutate (mutation, args, apolloClient) { | |
} | ||
// command in a different format (e.g. info command) | ||
return [TaskState.SUBMITTED, result] | ||
} catch { | ||
} catch (error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think one of the Webpack loaders was not happy about this syntax, even though it was working before. I think a new and more strict rule was added somewhere in some dependency 🤷♂️ |
||
return _mutateError(mutation.name, 'invalid response', response) | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,11 @@ module.exports = { | |
publicPath: '', | ||
outputDir: 'dist', | ||
indexPath: 'index.html', | ||
transpileDependencies: ['vuetify', 'graphql-language-service-interface', 'graphql-language-service-parser'], | ||
transpileDependencies: [ | ||
'graphql-language-service-interface', | ||
'graphql-language-service-parser', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These two dependencies broke the build due to the null-coallesce operator. I think that could happen in our current Yarn V1 build too at some point? |
||
'vuetify' | ||
], | ||
runtimeCompiler: true, | ||
productionSourceMap: process.env.NODE_ENV !== 'production', | ||
pluginOptions: { | ||
|
@@ -74,13 +78,15 @@ module.exports = { | |
} | ||
|
||
// coverage | ||
config.module.rule('istanbul') | ||
.test(/\.js$/) | ||
.include.add(path.resolve('src')).end() | ||
.use('istanbul-instrumenter-loader') | ||
.loader('istanbul-instrumenter-loader') | ||
.options({ esModules: true }) | ||
.before('babel-loader') | ||
if (process.env.coverage === 'true') { | ||
config.module.rule('istanbul') | ||
.test(/\.js$/) | ||
.include.add(path.resolve('src')).end() | ||
.use('istanbul-instrumenter-loader') | ||
.loader('istanbul-instrumenter-loader') | ||
.options({ esModules: true }) | ||
.after('cache-loader') | ||
} | ||
|
||
// resolve modules in devtool | ||
config.output | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yarn failed to build due to the old syntax? 🤷♂️ copied this from the autoprefixer docs.