feat: add explicit check against codeCoverage.expectFrontendCoverageOnly before attempting to collect backend coverage #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly before attempting to collect backend coverage
|
|
mcaverick
approved these changes
Jul 15, 2021
|
Please release a version with this change. @maartencardinaels @funkadelic |
|
@funkadelic is this PR still planned? My monitoring is showing all of these failing requests... |
|
@maartencardinaels thanks for the PR approval; is there anything else needed from my end to get this merged down to master & released? |
one of the project collaborators will have to merge this PR |
|
Could this be revisited? What steps are required to get it through? |
|
I forked from master and brought in the same changes @funkadelic has. Therefore the PR I created is an updated duplicate of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #473. See #473 for details behind the change