Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add node12.0.0-chrome73-ff68 #156

Merged
merged 1 commit into from
Oct 18, 2019
Merged

add node12.0.0-chrome73-ff68 #156

merged 1 commit into from
Oct 18, 2019
+64 −0

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Oct 17, 2019 •
edited
Loading

fix #150

  • includes codecs needed for video playback

@kuceb kuceb requested a review from bahmutov October 17, 2019 22:27
@chrisbreiding chrisbreiding mentioned this pull request Oct 17, 2019
Merged
22 tasks
@bahmutov
Copy link
Contributor

bahmutov commented Oct 17, 2019 via email

@kuceb
Copy link
Contributor Author

kuceb commented Oct 17, 2019

I'm just trying to add firefox to the docker image we currently use in develop, I don't see a need to bake in a chrome upgrade

@bahmutov bahmutov merged commit 8d80ffe into master Oct 18, 2019
bahmutov
bahmutov reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super, pushed it

@mjhenkes mjhenkes deleted the node12.0.0-chrome73-ff68 branch April 14, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add video codecs to firefox dockerfiles
2 participants
@kuceb @bahmutov