-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libgbm-dev to 8.0.0 base image #332
Conversation
@flotwig is this for breaking change release v5? Because we won't support Node 8 I think, so we don't need this image |
@bahmutov Yeah, but the PR for Node 10 isn't done yet, so I'm updating this image to unblock the Electron 9 upgrade PR. Figured it was the simplest way to decouple the work. |
ughh, I really, really, really would not want to update the existing image, since people have been using it for a while and can get new versions of a lib there. Very dangerous. |
I can add the |
do the |
* chore(deps): electron@9.0.5 BREAKING CHANGE: libgbm is a requirement * update node, xcode, docker images * lockfile * chore(types): tsify lib/gui/windows and spec * fix Electron extension loading global extension loading was deprecated in 9, now has to be per-session * make windows fns stubbable * update electron_spec * tsify issue_173_spec * use upstream foxdriver to fix FF >= 75 see benmalka/foxdriver#7 * update test * for now, install libgbm-dev at ci time see cypress-io/cypress-docker-images#332 * fix open mode * remove devtools-ext dir
Do we need to also update the node 10 image? |
@brian-mann the Node 10 base image already has it, we should update the |
@flotwig haven't we already done that here? https://github.com/cypress-io/cypress/pull/7650/files#diff-29944324a3cbf9f4bd0162dfe3975d88R1095 |
yup looks right |
Did this actually need to bring in the |
I think you may be right, just |
Note: Cypress now requires Node 10+ so we don’t expect anything to be done for Node 8 base images
…Sent from my iPhone
On Aug 26, 2020, at 10:33, Zach Bloomquist ***@***.***> wrote:
Did this actually need to bring in the -dev package of libgbm? Cypress isn't building anything against that library right? It is only a dependency of Chrome? Same goes for the libnotify packages I suppose.
I think you may be right, just libgbm would have sufficed. Would be down to improve how we do this for future docker images.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I tried using |
to fix https://circleci.com/gh/cypress-io/cypress/377914?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
on cypress-io/cypress#7791
@bahmutov since this is an update to an existing image, will it need to be manually uploaded to docker hub?