Installing Cypress guide improvment #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
closes cypress-io#200, closes cypress-io#218 and closes cypress-io/cypress#866 * npm install section clarification - what is the npm package - best practice highlighted * direct download section precisions - what is exactly downloaded as the user didn't knew it exactly * new CDN Structure section - CDN url pattern - it give to the user enough informations to download Cypress in the wanted version for the wanted platform (could download a linux Cypress version from a windows workstation) - example * Advanced section - warning added about CLI output when running cypress
MarcLoupias
force-pushed
the
installing-cypress-improvement
branch
from
bc88197 to
cbc0daf
Compare
- Some wording changes - Moved CDN section into section called ‘Hosting’ within the Advanced install instructions. - Added the download table (we only want to expose our download.cypress.io endpoint, not the cdn directly) - update platforms to correct os names.
jennifer-shehane
approved these changes
Nov 6, 2017
|
Ok :) Should i do something ? I see an "Update branch" button, i don't know what it does exactly under the hood, i am used to gitlab at work and never used github for something else then personal projects. At work i would have pulled your changes, pulled develop changes then |
|
A Cypress maintainer needs to merge in the changes. I was waiting for the tests to pass then got distracted. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #200, closes #218 and closes cypress-io/cypress#866
version for the wanted platform (could download a linux Cypress version from
a windows workstation)