Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.8.0 Release #2856

Merged
merged 14 commits into from
Jun 8, 2020
Merged

4.8.0 Release #2856

merged 14 commits into from
Jun 8, 2020

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jun 5, 2020


Preview of main content for 'test config' feature

Screen Shot 2020-06-08 at 2 16 00 PM

Screen Shot 2020-06-08 at 2 16 09 PM

Copy link
Member

@brian-mann brian-mann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we are not sufficiently highlighting the browser test configuration override.

It's mentioned in the isBrowser API (although way at the bottom and underneath all of the other use cases, even though it is the primary use case of that method.

It's also mentioned in the cross browser doc, but I feel like it should be mentioned in the configuration area, or somewhere with more real estate.

source/_changelogs/4.8.0.md Outdated Show resolved Hide resolved
source/guides/guides/cross-browser-testing.md Outdated Show resolved Hide resolved
source/guides/references/configuration.md Outdated Show resolved Hide resolved
@CypressCecelia
Copy link
Contributor

@jennifer-shehane There's a typo in the Test Configuration documentation in the screenshot (couldn't find where the actual file was changed, I think that's a separate PR). In the "Note" with the red caution sign, the second sentence says

"The following...can be changed via per test configuration."

It should be either via or per, not both.

@brian-mann
Copy link
Member

brian-mann commented Jun 8, 2020

@jennifer-shehane There's a typo in the Test Configuration documentation in the screenshot (couldn't find where the actual file was changed, I think that's a separate PR). In the "Note" with the red caution sign, the second sentence says

"The following...can be changed via per test configuration."

It should be either via or per, not both.

Maybe:

  • by individual test configuration
  • with individual test configuration
  • by specific test configuration
  • with specific test configuration

@flotwig
Copy link
Contributor

flotwig commented Jun 8, 2020

couldn't find where the actual file was changed, I think that's a separate PR

same, can't find it, so let's go ahead with this PR as-is for now since it's not in this PR

@flotwig flotwig merged commit ef67689 into develop Jun 8, 2020
@matthamil matthamil deleted the 4.8.0-release branch April 14, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants