Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 5.0.0 release docs test retries #2925

Merged
merged 35 commits into from
Aug 13, 2020
Merged

docs: 5.0.0 release docs test retries #2925

merged 35 commits into from
Aug 13, 2020

Conversation

bencodezen
Copy link
Contributor

@bencodezen bencodezen commented Jun 24, 2020 •
edited by jennifer-shehane
Loading

Close #2688

For cypress-io/cypress#3968

For some reason, I can't change the destination branch for this PR to go into the 5.0.0 release branch. Is this a permissions thing?

@bencodezen bencodezen closed this Jun 24, 2020
@bencodezen bencodezen reopened this Jun 25, 2020
@jennifer-shehane
Copy link
Member

@bencodezen Maybe? I've update DX team to have admin permissions on this repo.

@jennifer-shehane jennifer-shehane changed the base branch from develop to 5.0.0-release June 26, 2020 06:16
jennifer-shehane
jennifer-shehane requested changes Jun 26, 2020
View reviewed changes
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
@jennifer-shehane
Copy link
Member

Need to include the file in all languages or our tests will fail and the other languages won't have the file.

@jennifer-shehane jennifer-shehane mentioned this pull request Jun 26, 2020
Merged
14 tasks
bencodezen and others added 3 commits June 29, 2020 13:34
@bencodezen @jennifer-shehane
Update source/guides/guides/test-retries.md
f3c6961 
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@bencodezen @jennifer-shehane
docs: apply suggestions from Jen's code review
f4715fa 
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@bencodezen @jennifer-shehane
docs: add more improvements from Jen's code review
e846f56 
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@jennifer-shehane
Copy link
Member

This PR is missing the actual documentation for the feature elsewhere in the docs outside of the test retries guide. I'll be making some commits to this PR for those changes.

@jennifer-shehane
Copy link
Member

There's still many mentions of Cypress 5.0 in the test-retries doc. See my comment: #2925 (comment)

kuceb
kuceb suggested changes Aug 10, 2020
View reviewed changes
source/guides/core-concepts/writing-and-organizing-tests.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
@jennifer-shehane
Copy link
Member

I committed most of @bkucera's recommendations

@jennifer-shehane
Copy link
Member

Need to update this section on 'Debugging flake' to recommend they try 'Test Retries' https://github.com/cypress-io/cypress-documentation/blob/5.0.0-release-docs-test-retries/source/guides/guides/debugging.md#L134:L134

JessicaSachs
JessicaSachs suggested changes Aug 11, 2020
View reviewed changes
source/guides/core-concepts/writing-and-organizing-tests.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
source/guides/guides/test-retries.md Outdated Show resolved Hide resolved
JessicaSachs
JessicaSachs suggested changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on wording

bencodezen and others added 4 commits August 11, 2020 13:44
@bencodezen @JessicaSachs
docs: remove strategies piece
7ed0b1b 
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
@bencodezen @JessicaSachs
docs: clarify meaning
003b66f 
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
@bencodezen @JessicaSachs
docs: make phrasing more accurate
18b6a61 
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
@bencodezen @kuceb
docs: add specific image name
5fa4c6e 
Co-authored-by: Ben Kucera <14625260+Bkucera@users.noreply.github.com>
@bencodezen
Copy link
Contributor Author

Need to update this section on 'Debugging flake' to recommend they try 'Test Retries' https://github.com/cypress-io/cypress-documentation/blob/5.0.0-release-docs-test-retries/source/guides/guides/debugging.md#L134:L134

Which section are you referring to @jennifer-shehane?

@bencodezen
Copy link
Contributor Author

bencodezen commented Aug 11, 2020 •
edited
Loading

@bkucera @JessicaSachs changes and feedback applied!

@CypressCecelia
Copy link
Contributor

Which section are you referring to @jennifer-shehane?

https://docs.cypress.io/guides/guides/debugging.html#Debugging-flake

I created an issue to add test retries and the analytics blog post at #3068

@JessicaSachs JessicaSachs self-requested a review August 11, 2020 21:59
JessicaSachs
JessicaSachs approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennifer-shehane jennifer-shehane dismissed their stale review August 12, 2020 07:30

Dismissing my previous review as addressed

@jennifer-shehane
Copy link
Member

Merging into 5.0 docs - we can make any last minute changes there is necessary.

@jennifer-shehane jennifer-shehane merged commit f5fbe09 into 5.0.0-release Aug 13, 2020
@jennifer-shehane jennifer-shehane mentioned this pull request Aug 17, 2020
Merged
57 tasks
@matthamil matthamil deleted the 5.0.0-release-docs-test-retries branch April 14, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CypressCecelia CypressCecelia CypressCecelia left review comments

@jennifer-shehane jennifer-shehane jennifer-shehane left review comments

@JessicaSachs JessicaSachs JessicaSachs approved these changes

@kuceb kuceb Awaiting requested review from kuceb

Assignees
No one assigned
Labels
5.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bencodezen @jennifer-shehane @CypressCecelia @JessicaSachs @kuceb