Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for click modifiers. #3062

Merged
merged 5 commits into from
Aug 17, 2020

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Aug 6, 2020

Related to cypress-io/cypress#8114

Base branch is develop. Please check it before merge.

@sainthkh
Copy link
Contributor Author

sainthkh commented Aug 6, 2020

It seems that something went wrong with npm.

@jennifer-shehane jennifer-shehane mentioned this pull request Aug 10, 2020
14 tasks
@jennifer-shehane jennifer-shehane marked this pull request as draft August 10, 2020 08:34
@jennifer-shehane
Copy link
Member

Updated the examples in each doc for how to use key modifiers (instead of through .type()) and cross linked between the docs.

@jennifer-shehane jennifer-shehane self-requested a review August 10, 2020 09:10
@sainthkh
Copy link
Contributor Author

sainthkh commented Aug 11, 2020

In click doc, the options are ordered alphabetically. But rightclick and dblclick are not. It seems that they're forgotten. I fixed them in the commit below.

@sainthkh sainthkh marked this pull request as ready for review August 11, 2020 02:11
@jennifer-shehane jennifer-shehane changed the base branch from develop to 5.0.0-release August 13, 2020 15:11
@jennifer-shehane jennifer-shehane merged commit 776929a into cypress-io:5.0.0-release Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants