Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Studio experimental version docs #3394

Merged
merged 20 commits into from
Jan 19, 2021

Conversation

amirrustam
Copy link
Contributor

@amirrustam amirrustam commented Dec 11, 2020

Comment on lines +31 to +36
cy.task('db:seed')

// Login test user
cy.database('find', 'users').then((user) => {
cy.login(user.username, 's3cret', true)
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would discourage against having code here that can't be copy/pasted and work with no other code in their project. People will copy/paste this and get an error like 'cy.database is not defined' and 'cy.login is not defined' and be confused.

@kevinold kevinold marked this pull request as ready for review January 15, 2021 22:59
@kevinold kevinold assigned amirrustam and kevinold and unassigned amirrustam Jan 15, 2021
@kevinold
Copy link
Contributor

@amirrustam Ready for review

@jennifer-shehane jennifer-shehane changed the base branch from develop to 6.3.0-release January 19, 2021 15:43
@jennifer-shehane
Copy link
Member

I've updated the base branch to 6.3.0-release branch, so that this will be merged and released along with all 6.3.0 docs.

@jennifer-shehane jennifer-shehane mentioned this pull request Jan 19, 2021
4 tasks
@amirrustam
Copy link
Contributor Author

@jennifer-shehane looks like we did this exactly at the same time! GH was erroring out!

@chrisbreiding chrisbreiding merged commit 6eb6386 into 6.3.0-release Jan 19, 2021
@matthamil matthamil deleted the kevin/cypress-studio-mvp-v1 branch April 14, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants