Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break best practices into subpages #5132

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Break best practices into subpages #5132

wants to merge 2 commits into from

Conversation

jaffrepaul
Copy link
Contributor

No description provided.

@jaffrepaul jaffrepaul marked this pull request as draft March 21, 2023 19:04
jaffrepaul
jaffrepaul commented Oct 6, 2023
View reviewed changes
Copy link
Contributor Author

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asfjhbajhbfalv

jaffrepaul
jaffrepaul commented Oct 6, 2023
View reviewed changes
docs/guides/references/best-practices/assigning-return-values.mdx

:::tip

&#8239;<Icon name="check-circle" color="green" /> **Best Practice:** Use
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

jaffrepaul
jaffrepaul commented Oct 6, 2023
View reviewed changes
Copy link
Contributor Author

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aS

docs/guides/references/best-practices/assigning-return-values.mdx

:::

Many first time users look at Cypress code and think it runs synchronously.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uyADgckv

docs/guides/references/best-practices/assigning-return-values.mdx

// Instead, do this.
cy.get('a').as('links')
cy.get('@links').first().click()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

jaffrepaul
jaffrepaul commented Oct 6, 2023
View reviewed changes
docs/guides/references/best-practices/assigning-return-values.mdx
// THE WAY YOU THINK IT DOES.
const a = cy.get('a')

cy.visit('https://example.cypress.io')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cy.visit('https://example.cypress.io')
cy.visit('https://example.cypress.io/home')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstakoun pstakoun Awaiting requested review from pstakoun

@ryanpei ryanpei Awaiting requested review from ryanpei

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaffrepaul