Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address #23 add example of 'select' option #155

Closed
wants to merge 3 commits into from

Conversation

jeremybowden73
Copy link

Addresses issue #23: add example of 'select' option.

@jeremybowden73 jeremybowden73 changed the title address #23 address #23 add example of 'select' option Nov 21, 2018
@jennifer-shehane
Copy link
Member

@bahmutov I can't even figure out how to rerun these Shippable builds, do I have the correct permissions?

Also - the Travis run doesn't seem to be skipping recording on external PRs.

@bahmutov
Copy link
Contributor

bahmutov commented Dec 4, 2018

Hmm, why are the versions in this PR so old - Travis is showing

$ node --version
v6.5.0
$ npm --version
3.10.3
It looks like this is your first time using Cypress: 2.1.0

Let me see what is going on

@bahmutov
Copy link
Contributor

bahmutov commented Feb 7, 2019

@jeremybowden73 can I ask you to disable any kind of formatting in your text editor? I am looking at the changes in app/commands/actions.html and there are a lot of white space changes that seem unnecessary. Can you also pull the latest code from master into your branch?

The shippable and other test failures are flukes, other CIs pass without a problem.

@jeremybowden73
Copy link
Author

@bahmutov I've pulled the latest code from master, and removed all the white space changes that you mentioned.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jeremybowden73 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bahmutov
Copy link
Contributor

@jeremybowden73 I have added similar assertions in #349 will close your pull request - thank you for taking time to do this, really helpful

@bahmutov bahmutov closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants