Skip to content

Commit

Permalink
test: temporarily disable beforeEach assertion in issue 1244 regressi…
Browse files Browse the repository at this point in the history
…on test (#29288)

* misc: bump cache

* misc: temporarily disable issue 1244 tests to fix ci

* reenable 1244 tests, just comment out counters assertion

* Update packages/driver/cypress/e2e/issues/1244.cy.js

Co-authored-by: Matt Schile <mschile@cypress.io>

---------

Co-authored-by: Matt Schile <mschile@cypress.io>
  • Loading branch information
cacieprins and mschile authored Apr 9, 2024
1 parent 7410909 commit 00ea3de
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .circleci/cache-version.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Bump this version to force CI to re-create the cache from scratch.

04-2-24
04-8-24
9 changes: 8 additions & 1 deletion packages/driver/cypress/e2e/issues/1244.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@ describe('issue 1244', () => {

// not all pages that get unloaded during this spec have getCounters()
if (win.location.href.includes('issue-1244.html')) {
expect(win.getCounters()).to.deep.equal({ getCounter: 0, setCounter: 0 })
// TODO: re-enable when capture completes dom transition.
// getCounters is changed when setAttribute/getAttribute
// is called which is necessary for certain capture code to work.
// once dom transition is complete, that capture code will no
// longer rely on setAttribute/getAttribute.
// see: https://github.com/cypress-io/cypress-services/issues/7725

// expect(win.getCounters()).to.deep.equal({ getCounter: 0, setCounter: 0 })
}
})
})
Expand Down

6 comments on commit 00ea3de

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 00ea3de Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.7.3/linux-x64/develop-00ea3dec24d9277e1e6dd1df6c52cfde032da200/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 00ea3de Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.7.3/linux-arm64/develop-00ea3dec24d9277e1e6dd1df6c52cfde032da200/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 00ea3de Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.7.3/darwin-x64/develop-00ea3dec24d9277e1e6dd1df6c52cfde032da200/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 00ea3de Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.7.3/darwin-arm64/develop-00ea3dec24d9277e1e6dd1df6c52cfde032da200/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 00ea3de Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.7.3/win32-x64/develop-00ea3dec24d9277e1e6dd1df6c52cfde032da200/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 00ea3de Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.7.3/darwin-arm64/develop-00ea3dec24d9277e1e6dd1df6c52cfde032da200/cypress.tgz

Please sign in to comment.