test: update screenshot system-tests flake so that it no longer compa…

…res images for uniqueness that represent the same state (#20463)
cypress-io · Mar 4, 2022 · 2e62bbb · 2e62bbb · cypress-bot · Mar 4, 2022
1 parent ef3be70
commit 2e62bbb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/driver/cypress/integration/commands/net_stubbing_spec.ts b/packages/driver/cypress/integration/commands/net_stubbing_spec.ts
@@ -11,6 +11,8 @@ const testFail = (cb, expectedDocsUrl = 'https://on.cypress.io/intercept') => {
   })
 }
 
+// Due to an issue with requests leaking between tests, we need to ensure that routes are unique from test to test
+// See https://github.com/cypress-io/cypress/issues/20397
 let routeCount = 0
 const uniqueRoute = (route) => {
   routeCount += 1

diff --git a/system-tests/test/screenshots_spec.js b/system-tests/test/screenshots_spec.js
@@ -90,7 +90,9 @@ describe('e2e screenshots', () => {
           fs.statAsync(screenshot4).get('size'),
           fs.statAsync(screenshot5).get('size'),
           fs.statAsync(screenshot6).get('size'),
-          fs.statAsync(screenshot7).get('size'),
+          // Ignore comparing 6 and 7 since they can sometimes be the same since we take the screenshot as close to the failure as possible and
+          // the test run error may not have displayed yet. Leaving this commented in case we want to change this behavior in the future
+          // fs.statAsync(screenshot7).get('size'),
           fs.statAsync(screenshot8).get('size'),
           fs.statAsync(screenshot9).get('size'),
         ])