fix iframe placeholder html (#5296)

* fix iframe placeholder html, add test * add link to issue * remove added test, modify existing only
cypress-io · Oct 29, 2019 · 3182f62 · 3182f62 · cypress-bot · Oct 29, 2019
1 parent cffe8b8
commit 3182f62
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/driver/src/cy/snapshots.coffee b/packages/driver/src/cy/snapshots.coffee
@@ -84,7 +84,7 @@ create = ($$, state) ->
         </style>
         <p>&lt;iframe&gt; placeholder for #{iframe.src}</p>
       """
-      $placeholder[0].src = "data:text/html;charset=utf-8,#{encodeURI(contents)}"
+      $placeholder[0].src = "data:text/html;base64,#{window.btoa(contents)}"
 
   getStyles = (snapshot) ->
     styleIds = snapshotsMap.get(snapshot)

diff --git a/packages/driver/test/cypress/integration/cy/snapshot_spec.coffee b/packages/driver/test/cypress/integration/cy/snapshot_spec.coffee
@@ -89,9 +89,17 @@ describe "driver/src/cy/snapshots", ->
       it "replaces with placeholders that have src in content", ->
         $("<iframe src='generic.html' />").appendTo(cy.$$("body"))
 
+        ## NOTE: possibly switch to visual screenshot diffing in future
+        ## since data: iframes are considered cross-origin and we cannot
+        ## query into them and assert on contents
+        ## e.g. cy.get('iframe').toMatchScreenshot()
+
+        ## For now we parse the src attr and assert on base64 encoded content
         { body } = cy.createSnapshot(null, @$el)
         expect(body.find("iframe").length).to.equal(1)
-        expect(body.find("iframe")[0].src).to.include("generic.html")
+        expect(body.find("iframe")[0].src).to.include(";base64")
+
+        expect(atob(body.find("iframe")[0].src.split(',')[1])).to.include("generic.html")
 
       it "placeholders have same id", ->
         $("<iframe id='foo-bar' />").appendTo(cy.$$("body"))