fix: do not allow image markdown in assertions and command log (#17777)

packages/driver/cypress/integration/commands/assertions_spec.js

@@ -1197,6 +1197,20 @@ describe('src/cy/commands/assertions', () => {
         })
       })
     })
+
+    describe('escape markdown', () => {
+      // https://github.com/cypress-io/cypress/issues/17357
+      it('images', (done) => {
+        const text = 'hello world ![JSDoc example](/slides/img/jsdoc.png)'
+        const result = 'hello world ``![JSDoc example](/slides/img/jsdoc.png)``'
+
+        expectMarkdown(
+          () => expect(text).to.equal(text),
+          `expected **${result}** to equal **${result}**`,
+          done,
+        )
+      })
+    })
   })
 
   context('chai overrides', () => {

packages/driver/src/cy/chai.js

@@ -28,6 +28,7 @@ const leadingWhitespaces = /\*\*'\s*/g
 const trailingWhitespaces = /\s*'\*\*/g
 const whitespace = /\s/g
 const valueHasLeadingOrTrailingWhitespaces = /\*\*'\s+|\s+'\*\*/g
+const imageMarkdown = /!\[.*?\]\(.*?\)/g
 
 let assertProto = null
 let matchProto = null
@@ -130,6 +131,10 @@ chai.use((chai, u) => {
     })
   }
 
+  const escapeMarkdown = (message) => {
+    return message.replace(imageMarkdown, '``$&``')
+  }
+
   const replaceArgMessages = (args, str) => {
     return _.reduce(args, (memo, value, index) => {
       if (_.isString(value)) {
@@ -447,6 +452,7 @@ chai.use((chai, u) => {
       const actual = chaiUtils.getActual(this, customArgs)
 
       message = removeOrKeepSingleQuotesBetweenStars(message)
+      message = escapeMarkdown(message)
 
       try {
         assertProto.apply(this, args)