Skip to content

Commit

Permalink
Update window message: display 'yarn upgrade' instead of `yarn… (#7101)
Browse files Browse the repository at this point in the history
* update msg in update banner to use 'yarn upgrade' instead of `yarn add`

* update test + add percy snapshot
  • Loading branch information
jennifer-shehane authored Apr 23, 2020
1 parent cda67b1 commit 70c084a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ describe('Update Banner', function () {
it('modal has info about updating package.json', function () {
cy.get('.modal').contains(`npm install --save-dev cypress@${NEW_VERSION}`)

cy.get('.modal').contains(`yarn add cypress@${NEW_VERSION}`)
cy.get('.modal').contains(`yarn upgrade cypress@${NEW_VERSION}`)
cy.percySnapshot()
})

it('links to \'open\' doc on click of open command', function () {
Expand Down
3 changes: 1 addition & 2 deletions packages/desktop-gui/src/update/update-banner.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ class UpdateBanner extends Component {
<li>
<span>If using npm, run <code>npm install --save-dev cypress@{appStore.newVersion}</code></span>
<br/>
<span>If using yarn, run <code>yarn add cypress@{appStore.newVersion}</code></span>

<span>If using yarn, run <code>yarn upgrade cypress@{appStore.newVersion}</code></span>
</li>
<li>
<span>Run <a href='#' onClick={this._openCyOpenDoc}><code>node_modules/.bin/cypress open</code></a> to open the new version.</span>
Expand Down

4 comments on commit 70c084a

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 70c084a Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

You can install this pre-release platform-specific build using instructions at https://on.cypress.io/installing-cypress#Install-pre-release-version.

You will need to use custom CYPRESS_INSTALL_BINARY url and install Cypress using an url instead of the version.

export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/4.4.2/linux-x64/circle-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-307612/cypress.zip
npm install https://cdn.cypress.io/beta/npm/4.4.2/circle-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-307532/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 70c084a Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor has built the win32 ia32 version of the Test Runner.

You can install this pre-release platform-specific build using instructions at https://on.cypress.io/installing-cypress#Install-pre-release-version.

You will need to use custom CYPRESS_INSTALL_BINARY url and install Cypress using an url instead of the version.

Instructions are included below, depending on the shell you are using.

In Command Prompt (cmd.exe):

set CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/4.4.2/win32-ia32/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.zip
npm install https://cdn.cypress.io/beta/npm/4.4.2/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.tgz

In PowerShell:

$env:CYPRESS_INSTALL_BINARY = https://cdn.cypress.io/beta/binary/4.4.2/win32-ia32/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.zip
npm install https://cdn.cypress.io/beta/npm/4.4.2/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.tgz

In Git Bash:

export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/4.4.2/win32-ia32/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.zip
npm install https://cdn.cypress.io/beta/npm/4.4.2/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.tgz

Using cross-env:

If the above commands do not work for you, you can also try using cross-env:

npm i -g cross-env
cross-env CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/4.4.2/win32-ia32/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.zip npm install https://cdn.cypress.io/beta/npm/4.4.2/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 70c084a Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor has built the win32 x64 version of the Test Runner.

You can install this pre-release platform-specific build using instructions at https://on.cypress.io/installing-cypress#Install-pre-release-version.

You will need to use custom CYPRESS_INSTALL_BINARY url and install Cypress using an url instead of the version.

Instructions are included below, depending on the shell you are using.

In Command Prompt (cmd.exe):

set CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/4.4.2/win32-x64/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.zip
npm install https://cdn.cypress.io/beta/npm/4.4.2/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.tgz

In PowerShell:

$env:CYPRESS_INSTALL_BINARY = https://cdn.cypress.io/beta/binary/4.4.2/win32-x64/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.zip
npm install https://cdn.cypress.io/beta/npm/4.4.2/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.tgz

In Git Bash:

export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/4.4.2/win32-x64/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.zip
npm install https://cdn.cypress.io/beta/npm/4.4.2/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.tgz

Using cross-env:

If the above commands do not work for you, you can also try using cross-env:

npm i -g cross-env
cross-env CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/4.4.2/win32-x64/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.zip npm install https://cdn.cypress.io/beta/npm/4.4.2/appveyor-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-32381303/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 70c084a Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

You can install this pre-release platform-specific build using instructions at https://on.cypress.io/installing-cypress#Install-pre-release-version.

You will need to use custom CYPRESS_INSTALL_BINARY url and install Cypress using an url instead of the version.

export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/4.4.2/darwin-x64/circle-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-307648/cypress.zip
npm install https://cdn.cypress.io/beta/npm/4.4.2/circle-develop-70c084a7d4995e7b00c4e6b83e1aab9984e07c72-307628/cypress.tgz

Please sign in to comment.