fix: .contains() selects proper elements when inside a <form> (#25038)

* fix: .contains() selects proper elements when inside a <form>

* Fix withinSubject to always be jquery object, and always pass a dom element to findAllShadowRoots

* Typo in last commit

packages/driver/cypress/e2e/commands/querying/querying.cy.js

@@ -1014,6 +1014,11 @@ describe('src/cy/commands/querying', () => {
       })
     })
 
+    // https://github.com/cypress-io/cypress/issues/25019
+    it('can locate elements contained inside <form> containers', () => {
+      cy.get('#focus').contains('button', 'focusable')
+    })
+
     it('can find input type=submits by value', () => {
       cy.contains('input contains submit').then(($el) => {
         expect($el.length).to.eq(1)

packages/driver/src/cy/commands/querying/querying.ts

@@ -174,12 +174,8 @@ export default (Commands, Cypress, cy, state) => {
       try {
         let scope = userOptions.withinSubject || cy.getSubjectFromChain(withinSubject)
 
-        if (scope && scope[0]) {
-          scope = scope[0]
-        }
-
         if (includeShadowDom) {
-          const root = scope || cy.state('document')
+          const root = scope?.get(0) || cy.state('document')
           const elementsWithShadow = $dom.findAllShadowRoots(root)
 
           scope = elementsWithShadow.concat(root)
@@ -327,7 +323,7 @@ export default (Commands, Cypress, cy, state) => {
       let $el = cy.$$()
 
       subject.each((index, element) => {
-        getOptions.withinSubject = element
+        getOptions.withinSubject = cy.$$(element)
         $el = $el.add(getFn())
       })