clean up

cypress-io · Feb 2, 2022 · 7d01dfb · 7d01dfb · cypress-bot · Feb 2, 2022
1 parent 31ddc9e
commit 7d01dfb
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 62 deletions.
diff --git a/__snapshots__/upload-npm-package-spec.js b/__snapshots__/upload-npm-package-spec.js
diff --git a/__snapshots__/upload-unique-binary-spec.js b/__snapshots__/upload-unique-binary-spec.js
diff --git a/scripts/binary/upload.js b/scripts/binary/upload.js
@@ -155,10 +155,11 @@ module.exports = {
       .pipe(rename((p) => {
         // rename to standard filename for upload
         p.basename = path.basename(uploadPath, path.extname(uploadPath))
-        p.dirname = path.dirName(uploadPath)
+        p.dirname = path.dirname(uploadPath)
 
         return p
-      })).pipe(gulpDebug())
+      }))
+      .pipe(gulpDebug())
       .pipe(publisher.publish(headers))
       .pipe(awspublish.reporter())
       .on('error', reject)

diff --git a/scripts/unit/binary/upload-spec.js b/scripts/unit/binary/upload-spec.js
@@ -2,10 +2,8 @@ require('../../spec-helper')
 
 const snapshot = require('snap-shot-it')
 const la = require('lazy-ass')
-const os = require('os')
 
 /* eslint-env mocha */
-/* global sinon */
 describe('upload', () => {
   const upload = require('../../binary/upload')
 
@@ -29,27 +27,4 @@ describe('upload', () => {
       la(folder === 'desktop/3.3.0', 'wrong desktop folder', folder)
     })
   })
-
-  // TODO: update tests this was removed but missing a ton of tests here...
-  context.skip('getUploadDirName', () => {
-    it('returns folder with platform', () => {
-      const aws = {
-        folder: 'desktop',
-      }
-
-      sinon.stub(upload, 'getAwsObj').returns(aws)
-      sinon.stub(os, 'arch').returns('x64')
-
-      const folder = upload.getUploadDirName({
-        platform: 'darwin',
-        version: '3.3.0',
-      })
-
-      la(
-        folder === 'desktop/3.3.0/darwin-x64/',
-        'wrong upload desktop folder',
-        folder,
-      )
-    })
-  })
 })