Squashed commit of the following:

commit bcba5ed Author: AtofStryker <bglesias@gmail.com> Date: Mon Sep 16 10:48:55 2024 -0400 fix: fix checkbox click events for firefox 129 and up [run ci] commit 8eb40d0 Author: AtofStryker <bglesias@gmail.com> Date: Wed Sep 11 10:18:00 2024 -0400 update docker image to chrome 128 and firefox 130 [run ci] commit 095b3da Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Date: Mon Sep 16 14:26:26 2024 +0200 chore: re-sync yarn.lock (#30237) commit f9810d1 Author: Jennifer Shehane <jennifer@cypress.io> Date: Thu Sep 12 20:46:58 2024 -0400 fix: upgrade multiple dependencies with Snyk (#30226) Snyk has created this PR to upgrade: - react from 18.2.0 to 18.3.1. See this package in yarn: - react-dom from 18.2.0 to 18.3.1. See this package in yarn: See this project in Snyk: https://app.snyk.io/org/cypress-opensource/project/a5a63d46-02af-48cd-b608-ceae831d3196?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> commit 952c851 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Sep 12 14:14:43 2024 -0400 chore: Update Chrome (stable) to 128.0.6613.137 and Chrome (beta) to 129.0.6668.42 (#30214) * chore: Update Chrome (stable) to 128.0.6613.137 * chore: Update Chrome (stable) to 128.0.6613.137 and Chrome (beta) to 129.0.6668.42 --------- Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> commit 23e67e1 Author: Raymond Greeley <101662915+raygdev@users.noreply.github.com> Date: Wed Sep 11 11:33:27 2024 -0400 chore(deps): migrate to @tanstack/react-query (#30154) * Migrate to tanstack query * chore(deps): migrate to @tanstack/react-query --------- Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
cypress-io · Sep 16, 2024 · b0218e5 · b0218e5
1 parent 8170e08
commit b0218e5
Show file tree

Hide file tree

Showing 19 changed files with 216 additions and 187 deletions.
diff --git a/.circleci/cache-version.txt b/.circleci/cache-version.txt
@@ -1,3 +1,3 @@
 # Bump this version to force CI to re-create the cache from scratch.
 
-09-17-24
+09-17-24-test
diff --git a/.circleci/workflows.yml b/.circleci/workflows.yml
@@ -86,7 +86,7 @@ executors:
   # the Docker image with Cypress dependencies and Chrome browser
   cy-doc:
     docker:
-      - image: cypress/browsers-internal:node18.17.1-chrome124-ff125
+      - image: cypress/browsers-internal:node18.17.1-chrome128-ff130
     # by default, we use "medium" to balance performance + CI costs. bump or reduce on a per-job basis if needed.
     resource_class: medium
     environment:
@@ -105,7 +105,7 @@ executors:
   # Docker image with non-root "node" user
   non-root-docker-user:
     docker:
-      - image: cypress/browsers-internal:node18.17.1-chrome124-ff125
+      - image: cypress/browsers-internal:node18.17.1-chrome128-ff130
         user: node
     environment:
       PLATFORM: linux

diff --git a/browser-versions.json b/browser-versions.json
@@ -1,5 +1,5 @@
 {
-  "chrome:beta": "129.0.6668.29",
-  "chrome:stable": "128.0.6613.119",
+  "chrome:beta": "129.0.6668.42",
+  "chrome:stable": "128.0.6613.137",
   "chrome:minimum": "64.0.3282.0"
 }
diff --git a/cli/CHANGELOG.md b/cli/CHANGELOG.md
@@ -1,7 +1,11 @@
 <!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
 ## 13.14.3
 
-_Released 9/10/2024 (PENDING)_
+_Released 9/24/2024 (PENDING)_
+
+**Bugfixes:**
+
+- Fixed an issue where Firefox was incorrectly mutating the state of click events on checkboxes after Firefox version `129` and up. Addressed in [#30245](https://github.com/cypress-io/cypress/pull/30245).
 
 **Dependency Updates:**
 

diff --git a/npm/vite-plugin-cypress-esm/cypress/component/edgeCases.cy.tsx b/npm/vite-plugin-cypress-esm/cypress/component/edgeCases.cy.tsx
@@ -48,7 +48,7 @@ describe('edge cases', () => {
    * This library has some weird things going on with prototypes
    * under the hood.
    */
-  it('works with react-query', () => {
+  it('works with @tanstack/react-query', () => {
     mount(<App />)
   })
 

diff --git a/npm/vite-plugin-cypress-esm/cypress/component/fixtures/reactQuery.tsx b/npm/vite-plugin-cypress-esm/cypress/component/fixtures/reactQuery.tsx
@@ -3,7 +3,7 @@ import {
   useQueryClient,
   QueryClient,
   QueryClientProvider,
-} from 'react-query'
+} from '@tanstack/react-query'
 import React from 'react'
 
 // Create a client
@@ -27,7 +27,7 @@ function Todos () {
   const mutation = useMutation(postTodo, {
     onSuccess: () => {
       // Invalidate and refetch
-      queryClient.invalidateQueries('todos')
+      queryClient.invalidateQueries({ queryKey: ['todos'] })
     },
   })
 

diff --git a/npm/vite-plugin-cypress-esm/package.json b/npm/vite-plugin-cypress-esm/package.json
@@ -17,11 +17,11 @@
     "picomatch": "2.3.0"
   },
   "devDependencies": {
+    "@tanstack/react-query": "4.36.1",
     "@types/picomatch": "2.3.0",
     "@vitejs/plugin-react": "4.3.0",
     "react": "16.8.6",
     "react-dom": "16.8.6",
-    "react-query": "3.39.3",
     "react-router": "6.10.0",
     "react-router-dom": "6.10.0",
     "vite": "5.2.11"

diff --git a/packages/driver/src/cy/commands/actions/type.ts b/packages/driver/src/cy/commands/actions/type.ts
@@ -192,6 +192,7 @@ export default function (Commands, Cypress, cy, state, config) {
       const isFirefoxBefore91 = Cypress.isBrowser('firefox') && Cypress.browserMajorVersion() < 91
       const isFirefoxBefore98 = Cypress.isBrowser('firefox') && Cypress.browserMajorVersion() < 98
       const isFirefox106OrLater = Cypress.isBrowser('firefox') && Cypress.browserMajorVersion() >= 106
+      const isFirefox129OrLater = Cypress.isBrowser('firefox') && Cypress.browserMajorVersion() >= 129
 
       const simulateSubmitHandler = function () {
         const form = options.$el.parents('form')
@@ -385,9 +386,9 @@ export default function (Commands, Cypress, cy, state, config) {
 
             keydownEvents = []
 
-            // After Firefox 98,
+            // After Firefox 98 and before 129
             // Firefox doesn't update checkbox automatically even if the click event is sent.
-            if (Cypress.isBrowser('firefox')) {
+            if (Cypress.isBrowser('firefox') && !isFirefox129OrLater) {
               if (event.target.type === 'checkbox') {
                 event.target.checked = !event.target.checked
               } else if (event.target.type === 'radio') { // when checked is false, here cannot be reached because of the above condition

diff --git a/packages/server/lib/browsers/firefox.ts b/packages/server/lib/browsers/firefox.ts
@@ -420,6 +420,8 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc
       '-marionette',
       '-new-instance',
       '-foreground',
+      // if testing against older versions of Firefox to determine when a regression may have been introduced, uncomment the '-allow-downgrade' flag.
+      // '-allow-downgrade',
       '-start-debugger-server', // uses the port+host defined in devtools.debugger.remote
       '-no-remote', // @see https://github.com/cypress-io/cypress/issues/6380
     ],

diff --git a/system-tests/__snapshots__/component_testing_spec.ts.js b/system-tests/__snapshots__/component_testing_spec.ts.js
@@ -786,9 +786,9 @@ exports['experimentalSingleTabRunMode / executes all specs in a single tab'] = `
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails (fai     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails (fai     (1280x581)
      led).png                                                                                       
-  -  /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails agai     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails agai     (1280x581)
      n (failed).png                                                                                 
 
 

diff --git a/system-tests/__snapshots__/retries_spec.ts.js b/system-tests/__snapshots__/retries_spec.ts.js
@@ -164,8 +164,8 @@ exports['retries / supports retries (chrome)'] = `
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed).png            (1280x633)
-  -  /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed) (attempt 2     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed).png            (1280x581)
+  -  /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed) (attempt 2     (1280x581)
      ).png                                                                                          
 
 

diff --git a/system-tests/__snapshots__/vite_dev_server_fresh_spec.ts.js b/system-tests/__snapshots__/vite_dev_server_fresh_spec.ts.js
@@ -82,7 +82,7 @@ We dynamically generated a new test to display this failure.
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x581)
      s detected outside of a test (failed).png                                                      
 
 
@@ -165,12 +165,12 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x581)
      .png                                                                                           
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x633)
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x581)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x581)
      g                                                                                              
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x581)
      ).png                                                                                          
 
 
@@ -216,7 +216,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x581)
      ng                                                                                             
 
 
@@ -254,7 +254,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x581)
      his file (failed).png                                                                          
 
 
@@ -485,7 +485,7 @@ We dynamically generated a new test to display this failure.
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x581)
      s detected outside of a test (failed).png                                                      
 
 
@@ -568,12 +568,12 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x581)
      .png                                                                                           
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x633)
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x581)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x581)
      g                                                                                              
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x581)
      ).png                                                                                          
 
 
@@ -619,7 +619,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x581)
      ng                                                                                             
 
 
@@ -657,7 +657,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x581)
      his file (failed).png                                                                          
 
 
@@ -888,7 +888,7 @@ We dynamically generated a new test to display this failure.
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x581)
      s detected outside of a test (failed).png                                                      
 
 
@@ -971,12 +971,12 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x581)
      .png                                                                                           
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x633)
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x581)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x581)
      g                                                                                              
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x581)
      ).png                                                                                          
 
 
@@ -1022,7 +1022,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x581)
      ng                                                                                             
 
 
@@ -1060,7 +1060,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x581)
      his file (failed).png                                                                          
 
 
@@ -1291,7 +1291,7 @@ We dynamically generated a new test to display this failure.
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x581)
      s detected outside of a test (failed).png                                                      
 
 
@@ -1374,12 +1374,12 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x581)
      .png                                                                                           
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x633)
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x581)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x581)
      g                                                                                              
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x581)
      ).png                                                                                          
 
 
@@ -1425,7 +1425,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x581)
      ng                                                                                             
 
 
@@ -1463,7 +1463,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x581)
      his file (failed).png                                                                          
 
 
@@ -1906,7 +1906,7 @@ We dynamically generated a new test to display this failure.
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa     (1280x581)
      s detected outside of a test (failed).png                                                      
 
 
@@ -1989,12 +1989,12 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed)     (1280x581)
      .png                                                                                           
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x633)
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png     (1280x581)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn     (1280x581)
      g                                                                                              
-  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed     (1280x581)
      ).png                                                                                          
 
 
@@ -2040,7 +2040,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p     (1280x581)
      ng                                                                                             
 
 
@@ -2078,7 +2078,7 @@ https://on.cypress.io/uncaught-exception-from-application
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x633)
+  -  /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t     (1280x581)
      his file (failed).png