Skip to content

Commit

Permalink
chore(deps): update dependency semantic-release to v19 [security] (#2…
Browse files Browse the repository at this point in the history
…2238)

* chore(deps): update dependency semantic-release to v19 [security]

* chore: try moving to semantic-release 18

* chore: update jasmine-core to 3.8.0

* chore: update semantic version 19.0.3

* fix: update test to deal with npm obscuring internal error code

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
Co-authored-by: Bill Glesias <bglesias@gmail.com>
  • Loading branch information
4 people authored Jun 27, 2022
1 parent 22d2c31 commit fac83fd
Show file tree
Hide file tree
Showing 6 changed files with 966 additions and 932 deletions.
2 changes: 1 addition & 1 deletion npm/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"raw-loader": "1.0.0",
"renderkid": "2.0.5",
"rxjs": "~6.6.0",
"semantic-release": "17.4.2",
"semantic-release": "19.0.3",
"to-string-loader": "1.1.6",
"ts-loader": "8.1.0",
"ts-node": "^10.2.1",
Expand Down
2 changes: 1 addition & 1 deletion npm/cypress-schematic/sandbox12/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@angular/compiler-cli": "~13.1.3",
"@types/jasmine": "~3.6.0",
"@types/node": "^12.11.1",
"jasmine-core": "~3.7.0",
"jasmine-core": "~3.8.0",
"karma": "~6.3.0",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.0.3",
Expand Down
2 changes: 1 addition & 1 deletion npm/webpack-preprocessor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"react-dom": "16.13.1",
"react-scripts": "3.2",
"rimraf": "3.0.2",
"semantic-release": "17.2.3",
"semantic-release": "19.0.3",
"sinon": "^9.0.0",
"sinon-chai": "^3.5.0",
"snap-shot-it": "7.9.2",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
"print-arch": "1.0.0",
"proxyquire": "2.1.3",
"rimraf": "3.0.2",
"semantic-release": "17.2.3",
"semantic-release": "19.0.3",
"semantic-release-monorepo": "7.0.3",
"semver": "7.3.2",
"shelljs": "0.8.5",
Expand Down
15 changes: 12 additions & 3 deletions packages/server/test/integration/cli_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,17 @@ describe('CLI Interface', () => {
describe('through NPM script', () => {
let npmVersion = null

const isNpmSlurpingCode = () => {
return semver.lt(npmVersion, '4.0.0')
/**
* In certain versions of npm, code with an exit code of 10 (Internal Runtime Javascript Failure)
* is ultimately displayed as an exit code of 1 (Uncaught Runtime Exception).
* This seems to occur before Node 7 / NPM 4 and after Node 14/ NPM 7.
* Please see https://github.com/arzzen/all-exit-error-codes/blob/master/programming-languages/javascript/nodejs.md
* for more details.
*
* @returns {boolean}
*/
const doesNpmObscureInternalExitCode = () => {
return semver.lt(npmVersion, '4.0.0') || semver.gt(npmVersion, '6.0.0')
}

beforeEach(() => {
Expand All @@ -111,7 +120,7 @@ describe('CLI Interface', () => {
})

it('npm slurps up or not exit value on failure', (done) => {
const expectedCode = isNpmSlurpingCode() ? 1 : 10
const expectedCode = doesNpmObscureInternalExitCode() ? 1 : 10
const s = cp.exec('npm run dev -- --exit-with-code=10')

return s.on('close', (code) => {
Expand Down
Loading

5 comments on commit fac83fd

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fac83fd Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.0/linux-x64/develop-fac83fd451acf8fff0691e10b8c13ec61449a37e/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fac83fd Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.0/linux-arm64/develop-fac83fd451acf8fff0691e10b8c13ec61449a37e/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fac83fd Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.0/win32-x64/develop-fac83fd451acf8fff0691e10b8c13ec61449a37e/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fac83fd Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.0/darwin-arm64/develop-fac83fd451acf8fff0691e10b8c13ec61449a37e/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fac83fd Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.0/darwin-x64/develop-fac83fd451acf8fff0691e10b8c13ec61449a37e/cypress.tgz

Please sign in to comment.