-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(component-testing): Search spec overflowing #15534
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@@ -7,7 +7,9 @@ | |||
width: 100%; | |||
padding: 8px; | |||
box-sizing: border-box; | |||
|
|||
background-color: white; | |||
z-index: 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you have a z-index
of 9, this is an incorrect assignment. z-index
is entirely based on stacking context, so if you're an old-school JS dev, setting z-index: 1000
or whatever didn't actually do anything special.
Most likely (without pulling down the branch and trying it myself) you want z-index: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. You can pull the branch and debug it yourself. I prefer tailwind style of indexing with a 10x. Previous is 1 new is 10 next is 100
When we have a lot of specs:
Before:
After: