Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-testing): Search spec overflowing #15534

Merged
merged 2 commits into from
Mar 17, 2021
Merged

fix(component-testing): Search spec overflowing #15534

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a1bc4
fix(component-testing): Search spec overflowing
dmtrKovalenko Mar 17, 2021
e8599d6
Merge branch 'develop' into fix/ct-search-spec-overflow
dmtrKovalenko Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/runner-ct/src/SpecList/components/SearchSpec.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
width: 100%;
padding: 8px;
box-sizing: border-box;

background-color: white;
z-index: 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you have a z-index of 9, this is an incorrect assignment. z-index is entirely based on stacking context, so if you're an old-school JS dev, setting z-index: 1000 or whatever didn't actually do anything special.

Most likely (without pulling down the branch and trying it myself) you want z-index: 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. You can pull the branch and debug it yourself. I prefer tailwind style of indexing with a 10x. Previous is 1 new is 10 next is 100


input {
width: 100%;
font-size: 18px;
Expand Down