Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IATR](M1.0) Running/completed build banner for debug page #24853

Closed
warrensplayer opened this issue Nov 28, 2022 · 1 comment
Closed

[IATR](M1.0) Running/completed build banner for debug page #24853

warrensplayer opened this issue Nov 28, 2022 · 1 comment
Assignees

Comments

@warrensplayer
Copy link
Contributor

warrensplayer commented Nov 28, 2022

Add support to show that a run is currently in progress to a developer and allow them to view the failed tests for a new run once it is complete.

There are three scenarios to support:

  • There are no completed relevant runs found for the current commit history for a branch, but an in-progress run is found.
    • The Debug will show the run header with an animated running status icon.
    • The body of the page will have a hero section with an image, a title of "Testing", and a subtitle of "X of X specs completed"
    • The values for the result counts and the sub title counts should reactively update when the information from the GraphQL query supplying the data is updated.

image

Figma

  • The developer is looking at a completed build, and the polling logic for relevant runs finds a newer in-progress run.
    • The Debug page will display a banner below the header and above the failed tests for the current run being viewed to let the developer know a new run is in progress.
    • The banner will show the same component with the running icon status and the run number. This will be followed by the commit message and text that indicates "X of X specs completed"

image

Figma

  • The developer is looking at a completed build and the previously found newer build that was in-progress has now completed.
    • The banner for the page will remain.
    • The status icon will switch to the icon representing the completed status (PASSED, FAILED, ERRORED, etc.)
    • The text at the end of the banner that originally indicated the number of specs completed in the in-progress run will now be a button styled as a link that says "View run". Clicking the link will update the page to now show that run's information in the Debug page.

image

Figma

Clickup: https://app.clickup.com/t/18033298/PM-2546
Figma Designs

@warrensplayer warrensplayer changed the title [IATR](M1) Running/completed build banner for debug page [IATR](M1.0) Running/completed build banner for debug page Dec 1, 2022
@warrensplayer
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants