-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: TypeScript: remove fallback for should
to increase type safety
#5573
Comments
should
to increase type safetyshould
to increase type safety
I tried to remove this, but I think that's impossible with current chai.js. There are too many valid combinations and we cannot cover everything. And we might block some valid assertions. And this type of error is not hard to find. It can be easily found by running tests once. So, I decided to add more types and leave the fallback. |
The code for this is done in cypress-io/cypress#8068, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Current behavior:
Desired behavior:
The text was updated successfully, but these errors were encountered: