AST rewriting not adding closing script tag when string is too long

[panzarino]

Current behavior:

The following test case, with experimentalSourceRewriting turned on, will not properly render the page. (It doesn't properly render the page without it either, see #1068)

  it('can open office online', () => {
    cy.visit('https://www.office.com/launch/excel?ms.officeurl=webapps&auth=2');

    cy.contains('Sign in').should('be', 'visible');
  });

It looks like when the source is being rewritten, something is causing the closing </script> tag to be omitted. When this tag is omitted, the rest of the page goes missing as well.

Here's what the rewritten response looks like:

Here's the actual response:

From some initial investigations it appears that this is a bug caused by the length of the script.

[jennifer-shehane]

I've seen an issue with the AUT not loading with this option in a few cases. Hopefully this addresses some of those. 🤞

[panzarino]

@jennifer-shehane Looks like we're not actually checking that the stream has finished being rewritten before returning the result, meaning long strings will complete after it returns: https://github.com/cypress-io/cypress/blob/develop/packages/rewriter/lib/html.ts#L17. Hopefully fixing with a PR later today.

[cypress-bot]

The code for this is done in cypress-io/cypress#8048, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 4.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.12.0, please open a new issue.