fix: AST rewriting when inline script is very long #8048
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -58,7 +58,7 @@ parentPort!.on('message', (req: RewriteRequest) => { | |||
| } | |||
|
|
|||
| try { | |||
| const output = _getOutput() | |||
| const output = await _getOutput() | |||
There was a problem hiding this comment.
@panzarino i thought this wasn't working like we expected, did you figure it out?
There was a problem hiding this comment.
It was working, turns out the issue I was seeing was from somewhere else and it was completely unrelated. I also tested the async functions specifically and it was working fine.
panzarino
changed the title
flotwig
changed the title
|
@flotwig it's split by the |
|
@panzarino That doesn't explain why this only happens after a certain body size, since the other test cases emit as one chunk. |
|
@flotwig Wasn't aware of that, not sure why its not working like that this time then. Should I be concerned with the failing server performance test? |
|
I think that's flake. |
User facing changelog
Fixes an issue where AST rewriting would return an output before the body was done being written. This would happen when the response body was too large and the response would be sent while the body was still being modified.
Additional details
This following test case would fail with the previous implementation, but now passes: https://github.com/cypress-io/cypress/pull/8048/files#diff-2aeeae49664314a9a544ffdea59ec137R55.
From the issue, here's an example of a body getting cut off:
Here's what the response looks like now:
Note: Thanks to Murphy's law, the test case from this issue still does not pass (due to something unrelated).
PR Tasks