Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in CLI errors.js #1138

Merged
merged 5 commits into from
Jan 2, 2018

Conversation

adam-binks
Copy link
Contributor

closes #1136

Hopefully everything is okay here, this is my first PR so let me know if not!

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2017

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane
Copy link
Member

🎉 Thanks for the contribution!

Most of our CLI output has some tests against them, so I imagine a test or two will fail. Oftentimes we 'snapshot' the previous CLI output and compare it to current CLI output, so those may need to be updated before we merge too. Let's see what the tests say when they're finished. :)

@jennifer-shehane jennifer-shehane self-requested a review January 2, 2018 18:22
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in CLI error for deps about Docker
3 participants