Add Firefox support

.eslintignore

@@ -25,7 +25,7 @@ packages/extension/test/helpers/background.js
 packages/server/lib/scaffold/plugins/index.js
 packages/server/lib/scaffold/support/index.js
 packages/server/lib/scaffold/support/commands.js
-
+packages/extension/app/browser-polyfill.js
 packages/launcher/lib/**/*.js
 
 **/package-lock.json

circle.yml

@@ -23,7 +23,15 @@ executors:
   # the Docker image with Cypress dependencies and Chrome browser
   cy-doc:
     docker:
-      - image: cypress/browsers:node12.0.0-chrome73
+      - image: cypress/browsers:node12.0.0-chrome73-ff68
+    environment:
+      PLATFORM: linux
+
+  # Docker image with non-root "node" user
+  non-root-docker-user:
+    docker:
+      - image: cypress/base:12.0.0
+        user: node
     environment:
       PLATFORM: linux
 
@@ -470,6 +478,62 @@ jobs:
           browser: electron
           chunk: 8
 
+  "server-e2e-tests-firefox-1":
+    <<: *defaults
+    steps:
+      - run-e2e-tests:
+          browser: firefox
+          chunk: 1
+
+  "server-e2e-tests-firefox-2":
+    <<: *defaults
+    steps:
+      - run-e2e-tests:
+          browser: firefox
+          chunk: 2
+
+  "server-e2e-tests-firefox-3":
+    <<: *defaults
+    steps:
+      - run-e2e-tests:
+          browser: firefox
+          chunk: 3
+
+  "server-e2e-tests-firefox-4":
+    <<: *defaults
+    steps:
+      - run-e2e-tests:
+          browser: firefox
+          chunk: 4
+
+  "server-e2e-tests-firefox-5":
+    <<: *defaults
+    steps:
+      - run-e2e-tests:
+          browser: firefox
+          chunk: 5
+
+  "server-e2e-tests-firefox-6":
+    <<: *defaults
+    steps:
+      - run-e2e-tests:
+          browser: firefox
+          chunk: 6
+
+  "server-e2e-tests-firefox-7":
+    <<: *defaults
+    steps:
+      - run-e2e-tests:
+          browser: firefox
+          chunk: 7
+
+  "server-e2e-tests-firefox-8":
+    <<: *defaults
+    steps:
+      - run-e2e-tests:
+          browser: firefox
+          chunk: 8
+
   "driver-integration-tests-chrome":
     <<: *defaults
     parallelism: 5
@@ -520,6 +584,30 @@ jobs:
   #         path: /tmp/artifacts
   #     - store-npm-logs
 
+  "driver-integration-tests-firefox":
+    <<: *defaults
+    parallelism: 3
+    steps:
+      - attach_workspace:
+          at: ~/
+      - run:
+          command: npm start
+          background: true
+          working_directory: packages/driver
+      - run:
+          command: $(npm bin)/wait-on http://localhost:3500
+          working_directory: packages/driver
+      - run:
+          command: |
+            CYPRESS_KONFIG_ENV=production \
+            CYPRESS_RECORD_KEY=$PACKAGES_RECORD_KEY \
+            npm run cypress:run -- --record --parallel --group 3x-driver-firefox --browser firefox
+          working_directory: packages/driver
+      - store_test_results:
+          path: /tmp/cypress
+      - store_artifacts:
+          path: /tmp/artifacts
+
   "desktop-gui-integration-tests-2x":
     <<: *defaults
     parallelism: 2
@@ -1007,9 +1095,36 @@ linux-workflow: &linux-workflow
     - server-e2e-tests-electron-8:
         requires:
           - build
+    - server-e2e-tests-firefox-1:
+        requires:
+          - build
+    - server-e2e-tests-firefox-2:
+        requires:
+          - build
+    - server-e2e-tests-firefox-3:
+        requires:
+          - build
+    - server-e2e-tests-firefox-4:
+        requires:
+          - build
+    - server-e2e-tests-firefox-5:
+        requires:
+          - build
+    - server-e2e-tests-firefox-6:
+        requires:
+          - build
+    - server-e2e-tests-firefox-7:
+        requires:
+          - build
+    - server-e2e-tests-firefox-8:
+        requires:
+          - build
     - driver-integration-tests-chrome:
         requires:
           - build
+    - driver-integration-tests-firefox:
+        requires:
+          - build
     ## TODO: add these back in when flaky tests are fixed
     # - driver-integration-tests-electron:
     #     requires:

cli/types/index.d.ts

@@ -64,6 +64,7 @@ declare namespace Cypress {
     path: string
     isHeaded: boolean
     isHeadless: boolean
+    family: string
   }
 
   interface LocalStorage {

packages/desktop-gui/src/app/nav.scss

@@ -152,6 +152,9 @@
   .canary > i { color: #e4b721; }
   .chromium > i { color: #829ac3; }
   .electron > i { color: #777; }
+  .firefox > i { color: #ff7d08; }
+  .firefox-developer-edition > i { color: #006ad9; }
+  .firefox-nightly > i { color: #a752f7; }
 
   .dropdown-menu {
     left: auto;

packages/driver/package.json

@@ -62,7 +62,7 @@
     "url-parse": "1.4.7",
     "vanilla-text-mask": "5.1.1",
     "wait-on": "3.3.0",
-    "webpack": "4.41.0",
+    "webpack": "4.41.2",
     "zone.js": "0.9.0"
   },
   "files": [

packages/driver/src/cy/actionability.coffee

@@ -203,7 +203,7 @@ getCoordinatesForEl = (cy, $el, options) ->
     $dom.getElementCoordinatesByPositionRelativeToXY($el, options.x, options.y)
   else
     # Cypress.dom.getElementCoordinatesByPosition($el, options.position)
-    $dom.getElementCoordinatesByPosition($el, options.position)
+    return $dom.getElementCoordinatesByPosition($el, options.position)
 
 ensureNotAnimating = (cy, $el, coordsHistory, animationDistanceThreshold) ->
   ## if we dont have at least 2 points

packages/driver/src/cy/chai.coffee

@@ -4,6 +4,7 @@ _ = require("lodash")
 $ = require("jquery")
 chai = require("chai")
 sinonChai = require("@cypress/sinon-chai")
+chaiInspect = require('./chai/inspect')
 
 $dom = require("../dom")
 $utils = require("../cypress/utils")
@@ -34,6 +35,12 @@ chaiUtils = null
 
 chai.use(sinonChai)
 
+
+getType = (val) ->
+  match = /\[object (.*)\]/.exec(Object.prototype.toString.call(val))
+  return match && match[1]
+
+
 chai.use (chai, u) ->
   chaiUtils = u
 
@@ -67,7 +74,17 @@ chai.use (chai, u) ->
   lengthProto  = chai.Assertion::__methods.length.method
   containProto = chai.Assertion::__methods.contain.method
   existProto   = Object.getOwnPropertyDescriptor(chai.Assertion::, "exist").get
-  getMessage   = chaiUtils.getMessage
+  objDisplay   = chai.util.objDisplay
+  getMessage   = chai.util.getMessage
+  _inspect = chai.util.inspect
+
+
+  {inspect, setFormatValueHook} = chaiInspect.create(chai)
+
+  setFormatValueHook (ctx, val) ->
+    if val && getType(val) is 'Window'
+      return '[window]'
+
 
   removeOrKeepSingleQuotesBetweenStars = (message) ->
     ## remove any single quotes between our **, preserving escaped quotes
@@ -95,20 +112,61 @@ chai.use (chai, u) ->
     , []
 
   restoreAsserts = ->
-    chaiUtils.getMessage = getMessage
-
+    chai.util.inspect = _inspect
+    chai.util.getMessage = getMessage
+    chai.util.objDisplay = objDisplay
     chai.Assertion::assert = assertProto
     chai.Assertion::match = matchProto
     chai.Assertion::__methods.length.method = lengthProto
     chai.Assertion::__methods.contain.method = containProto
 
     Object.defineProperty(chai.Assertion::, "exist", {get: existProto})
 
-  overrideChaiAsserts = (assertFn) ->
-    _this = @
 
+
+  overrideChaiInspect = () ->
+    chai.util.inspect = inspect
+
+  overrideChaiObjDisplay = ->
+    chai.util.objDisplay = (obj) ->
+      str = chai.util.inspect(obj)
+      type = Object::toString.call(obj)
+      if chai.config.truncateThreshold and str.length >= chai.config.truncateThreshold
+        if type == '[object Function]'
+          if !obj.name or obj.name == '' then '[Function]' else '[Function: ' + obj.name + ']'
+        else if type == '[object Array]'
+          '[ Array(' + obj.length + ') ]'
+        else if type == '[object Object]'
+          keys = Object.keys(obj)
+          kstr = if keys.length > 2 then keys.splice(0, 2).join(', ') + ', ...' else keys.join(', ')
+          '{ Object (' + kstr + ') }'
+        else
+          str
+      else
+        str
+
+  overrideChaiAsserts = (assertFn) ->
     chai.Assertion.prototype.assert = createPatchedAssert(assertFn)
 
+    _origGetmessage = (obj, args) ->
+      negate = chaiUtils.flag(obj, 'negate')
+      val = chaiUtils.flag(obj, 'object')
+      expected = args[3]
+      actual = chaiUtils.getActual(obj, args)
+      msg = (if negate then args[2] else args[1])
+      flagMsg = chaiUtils.flag(obj, 'message')
+
+      if typeof msg is "function"
+        msg = msg()
+
+      msg = msg || ''
+      msg = msg
+        .replace(/#\{this\}/g, -> chaiUtils.objDisplay(val))
+        .replace(/#\{act\}/g, -> chaiUtils.objDisplay(actual))
+        .replace(/#\{exp\}/g, -> chaiUtils.objDisplay(expected))
+
+      return (if flagMsg then flagMsg   + ': ' + msg else msg)
+
     chaiUtils.getMessage = (assert, args) ->
       obj = assert._obj
 
@@ -117,7 +175,12 @@ chai.use (chai, u) ->
         ## replace object with our formatted one
         assert._obj = $dom.stringify(obj, "short")
 
-      msg = getMessage.call(@, assert, args)
+      ## FIXME: (firefox) find a better way to prevent tunneling into Window objects,
+      ##   which leads to cross-origin errors and perf issues.
+      args[3] && args[3].view && args[3].view = null
+      args[4] && args[4].view && args[4].view = null
+
+      msg = _origGetmessage.call(@, assert, args)
 
       ## restore the real obj if we changed it
       if obj isnt assert._obj
@@ -314,7 +377,8 @@ chai.use (chai, u) ->
     # restoreOverrides()
     restoreAsserts()
 
-    # overrideChai()
+    overrideChaiInspect()
+    overrideChaiObjDisplay()
     overrideChaiAsserts(assertFn)
 
     return setSpecWindowGlobals(specWindow)