Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add session support #14350

Merged
merged 80 commits into from
Aug 4, 2021
Merged

feat: add session support #14350

merged 80 commits into from
Aug 4, 2021

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Dec 30, 2020

User facing changelog

changes to default blank page and useSession blank page:

before after
image image
n/a image

Additional details

How has the user experience changed?

PR Tasks

  • remove user facing api changes to getCookie/setCookie, support hostOnly in backend only

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 30, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 30, 2020



Test summary

8276 0 100 4Flakiness 1


Run details

Project cypress
Status Passed
Commit 8d53c5b
Started Aug 4, 2021 2:12 PM
Ended Aug 4, 2021 2:22 PM
Duration 10:16 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can incrementally wait on responses

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kuceb kuceb changed the title add session support feat:add session support Dec 31, 2020
@kuceb kuceb changed the title feat:add session support feat: add session support Dec 31, 2020
@kuceb kuceb marked this pull request as ready for review January 4, 2021 15:08
@kuceb kuceb requested a review from a team as a code owner April 12, 2021 21:08
flotwig
flotwig previously approved these changes Aug 3, 2021
Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@kuceb kuceb requested a review from flotwig August 4, 2021 13:22
chrisbreiding
chrisbreiding previously approved these changes Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants