feat(component-testing): Component testing runner splash screen #15091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
dmtrKovalenko
commented
Feb 15, 2021
packages/runner-ct/cypress/component/SpecList/SpecList.spec.tsx
Outdated
Show resolved
Hide resolved
dmtrKovalenko
commented
Feb 15, 2021
| className={cs('reporter-pane', { 'is-reporter-resizing': isResizing })} | ||
| > | ||
| <div> | ||
| {state.spec && ( | ||
| <div style={{ height: '100%' }}> |
There was a problem hiding this comment.
A utility class like full-height will be perfect here, but I don't like global styles :) so instead of making another specs-list-runner-container inlining the style makes it more clear what we need right here
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
JessicaSachs
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here what the user will see once component testing is open:
This PR also includes a lot of small UI bugfixes that I found, you can review them one-by-one by following the commits: