Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): crop all odd resolutions to be even #15295

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Mar 2, 2021

User facing changelog

  • Fixed an issue that could cause an ffmpeg error ("width not divisible by 2") during video recording in Chromium-family browsers, including Chrome, Electron, and Edge.

Additional details

  • apparently the h264 codec requires an even resolution: https://stackoverflow.com/a/20848224/3474615
  • odd resolutions will error
  • this fixes the issue by cropping the video by 1 pixel on the right or bottom, as needed, to reach an even resolution
  • we already do this for Firefox

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 2, 2021

Thanks for taking the time to open a PR!

@flotwig flotwig requested a review from kuceb March 2, 2021 22:22
@cypress
Copy link

cypress bot commented Mar 2, 2021



Test summary

9364 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 7b12a50
Started Mar 2, 2021 10:11 PM
Ended Mar 2, 2021 10:23 PM
Duration 11:43 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@kuceb kuceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@pmerwin
Copy link

pmerwin commented Mar 11, 2021

any news on release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants