Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: studio icon displays properly on tests with long title #15415

Merged
merged 6 commits into from
Mar 16, 2021

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented Mar 11, 2021

User facing changelog

Fixes an issue where studio icon would not display properly for tests with long titles

I also added some additional tests (+ percy) regarding the icon on hover since it wasn't tested very well

How has the user experience changed?

Before:
Screen Shot 2021-02-22 at 1 36 44 PM

After:
Screen Shot 2021-03-10 at 19 18 55

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 11, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 11, 2021



Test summary

9392 0 119 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 7eb1d8e
Started Mar 16, 2021 2:16 AM
Ended Mar 16, 2021 2:28 AM
Duration 11:04 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions
Copy link
Contributor

Internal Jira issue: TR-705

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry for the delay on review - took off last week.

@jennifer-shehane
Copy link
Member

I'm not totally sure that percy is capturing the icon like you were expecting - should probably look over the snapshots before merging.

@panzarino
Copy link
Contributor Author

@jennifer-shehane Yeah looks like the hovering doesn't really work with the percy snapshots and since we use opacity doing something like .invoke('show') doesn't seem to work either. I've just removed the snapshots for now

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 17, 2021

Released in 6.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 17, 2021
@emilyrohrbough emilyrohrbough deleted the issue-15182 branch August 1, 2024 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Studio button is not displayed properly when a test has a long title
2 participants