-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: studio icon displays properly on tests with long title #15415
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Internal Jira issue: TR-705 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Sorry for the delay on review - took off last week.
I'm not totally sure that percy is capturing the icon like you were expecting - should probably look over the snapshots before merging. |
@jennifer-shehane Yeah looks like the hovering doesn't really work with the percy snapshots and since we use opacity doing something like |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Fixes an issue where studio icon would not display properly for tests with long titles
I also added some additional tests (+ percy) regarding the icon on hover since it wasn't tested very well
How has the user experience changed?
Before:
After:
PR Tasks