Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: exit with non-zero exit code on signal exit #15727

Merged
merged 2 commits into from
Apr 1, 2021
Merged

chore: exit with non-zero exit code on signal exit #15727

merged 2 commits into from
Apr 1, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Mar 31, 2021 •
edited
Loading

Internal-only - CLI already catches this correctly.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 31, 2021

Thanks for taking the time to open a PR!

@flotwig flotwig force-pushed the electron-code-1-signal branch from 2fb1b1c to 7e71850 Compare March 31, 2021 20:56
@flotwig flotwig changed the base branch from develop to 7.0-release March 31, 2021 20:56
@cypress
Copy link

cypress bot commented Mar 31, 2021 •
edited
Loading


Test summary

9507 • 0 • 111 • 3 • Flakiness 1

Run details
Project cypress
Status Passed
Commit 979babe
Started Apr 1, 2021 3:19 PM
Ended Apr 1, 2021 3:31 PM
Duration 11:20 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/retries.ui.spec.js 1 Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@JessicaSachs JessicaSachs mentioned this pull request Apr 1, 2021
Closed
5 tasks
@flotwig flotwig force-pushed the electron-code-1-signal branch from a1acd80 to 979babe Compare April 1, 2021 15:07
@flotwig flotwig requested a review from kuceb April 1, 2021 16:12
@flotwig flotwig marked this pull request as ready for review April 1, 2021 16:12
@flotwig flotwig requested a review from a team as a code owner April 1, 2021 16:12
@flotwig flotwig changed the title fix: exit with non-zero exit code on signal exit chore: exit with non-zero exit code on signal exit Apr 1, 2021
@flotwig
Copy link
Contributor Author

flotwig commented Apr 1, 2021

@bkucera i opened a separate issue for the 500 crash: #15747

@flotwig flotwig merged commit 897ee9c into 7.0-release Apr 1, 2021
@flotwig flotwig deleted the electron-code-1-signal branch January 24, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuceb kuceb kuceb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flotwig @kuceb