Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: missing human-interval is breaking binary #15761

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

JessicaSachs
Copy link
Contributor

@JessicaSachs JessicaSachs commented Apr 2, 2021

By chance I found a crasher introduced by #15699 when testingType was added to the dashboard requests yesterday morning. It was only visible when the binary was built and prevented CT from launching at all. It was a simple missed dep.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 2, 2021

Thanks for taking the time to open a PR!

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - will need to install from tar and test manually before merging.

We should add binary tests for CT asap.

@JessicaSachs JessicaSachs merged commit 32d4b6a into 7.0-release Apr 2, 2021
@cypress
Copy link

cypress bot commented Apr 2, 2021



Test summary

9492 0 111 3Flakiness 1


Run details

Project cypress
Status Passed
Commit eead9cd
Started Apr 2, 2021 8:33 AM
Ended Apr 2, 2021 8:44 AM
Duration 11:02 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 5, 2021
@emilyrohrbough emilyrohrbough deleted the fix/missed-human-interval-dep branch August 1, 2024 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants