feat: added wait before and after screenshot

[galr52]

added wait after screenshot

• Closes

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Has the original issue or this PR been tagged with a release in ZenHub?
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[CLAassistant]

All committers have signed the CLA.

[jennifer-shehane]

@galr52 Could you give an explanation on why this new feature is necessary or link to an existing issue where people have requested this feature?

We'd like an understanding on why anyone would want this feature. We're not likely to add features without understanding the benefit because it is more to maintain in the future. Thanks.

[galr52]

@galr52 Could you give an explanation on why this new feature is necessary or link to an existing issue where people have requested this feature?

We'd like an understanding on why anyone would want this feature. We're not likely to add features without understanding the benefit because it is more to maintain in the future. Thanks.

in my app i have a screen that rerender on window resize.
when i was trying to make a screenshot tests for that screen i faced an issue when the screen size is changing (the left panel is closing and etc).

i found this open issue #9443

with this feature i can workaround the issue, wait a few ms and let my screen rerender before the screenshot

[jennifer-shehane]

@galr52 Can you provide a failing test cast that would now be passing with this solution? We need tests for all fixes and new features.

Is there a reason adding cy.wait(xxx) instead would not work in your case?

Just off of this information, I think it would be more worthwhile to investigate the window:resize triggers on the screenshot than add an arbitrary wait feature. This seems to be adding a new feature to fix an issue instead of just fixing the issue outright.

[galr52]

@jennifer-shehane the only solution i could think about that can fix the resize issue is to wait for all the "before:screenshot" subscribers.

i cant provide a failing test because the image resolution is changing on screenshot events

cy.wait(xxx) wont fix the problem the because the screen is changing on 'before:screenshot' is emitted, and this occurs only when you take a screenshot (raise 'take:screenshot' event)

[jennifer-shehane]

@galr52 Thanks for taking the time with this PR. We'd like to see a solution for the resize events triggers overall instead of adding a generic wait before/after screenshot as a feature. Going to close this PR for now.