Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1601 - Update runs tab to match new api schemas #1604

Merged
merged 8 commits into from
Apr 23, 2018
Merged

Issue 1601 - Update runs tab to match new api schemas #1604

merged 8 commits into from
Apr 23, 2018

Conversation

jennifer-shehane
Copy link
Member

  • added 'object-schema' project, began updating fixture to match schema
  • add timer display component
  • add some util functions
  • update tests to actual test the run data
  • capital cased some messaging in the runs

bahmutov
bahmutov reviewed Apr 19, 2018
View reviewed changes
packages/desktop-gui/src/lib/utils.js

const total = _.compact([
durationHrs,
!!durationHrs || padMinutes ? padStart(durationMins, 2, '0') : durationMins,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my, this expression is complicated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is! I mean, all I want is this logic in this spec to pass, so if there's a less complicated way, I'm game -> https://github.com/cypress-io/cypress/pull/1604/files#diff-6a3f8282b23f89f40bb2248f3e7d5c64

bahmutov
bahmutov previously approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, a lot less "screaming" through caps

@jennifer-shehane
Copy link
Member Author

@bahmutov This last test is failing because the CI env's timezone is not set to America/New_York. I'm not as familiar with this project's circle.yml file. Could you update the desktop tests to use this timezone?

@bahmutov
Copy link
Contributor

Will do, I did it somewhere some time ago, if only I could remember where ...

@bahmutov
Copy link
Contributor

hahaha, of course, I set it in the dashboard repo

$ grep TZ circle.yml -B 5
    docker:
      - image: cypress/base:6
        environment:
          TERM: xterm
          npm_config_loglevel: warn
          TZ: "/usr/share/zoneinfo/America/New_York"

@jennifer-shehane jennifer-shehane merged commit 8ec87e9 into develop Apr 23, 2018
@jennifer-shehane jennifer-shehane deleted the issue-1601 branch July 24, 2018 16:55
This was referenced Aug 25, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifer-shehane @bahmutov