-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Wrap native methods in secondary domain #17303
chore: Wrap native methods in secondary domain #17303
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Wraps native methods when visiting a secondary domain, including focus/blur methods on elements, CSS insert/delete methods, and fetch when the experimental flag is on.
Pulls the wrapping out into its own module, so it can be called from the primary domain driver and the secondary domain driver.
Currently, it's not possible to test these in the way I would like, since that will require further work getting the command queue running in the secondary domain. I'll add tests when that work is completed.