Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Wrap native methods in secondary domain #17303

Merged
merged 5 commits into from
Jul 14, 2021

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Jul 13, 2021

Wraps native methods when visiting a secondary domain, including focus/blur methods on elements, CSS insert/delete methods, and fetch when the experimental flag is on.

Pulls the wrapping out into its own module, so it can be called from the primary domain driver and the secondary domain driver.

Currently, it's not possible to test these in the way I would like, since that will require further work getting the command queue running in the secondary domain. I'll add tests when that work is completed.

@chrisbreiding chrisbreiding requested a review from a team as a code owner July 13, 2021 13:19
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 13, 2021

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding requested review from flotwig and kuceb and removed request for a team July 13, 2021 13:19
@cypress
Copy link

cypress bot commented Jul 13, 2021



Test summary

18217 0 222 7Flakiness 9


Run details

Project cypress
Status Passed
Commit 2c1cbd5
Started Jul 13, 2021 1:21 PM
Ended Jul 13, 2021 1:34 PM
Duration 12:47 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 ... > automatically parses application/json response bodies
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
3 ... > sets body to string if JSON is malformed
4 ... > doesn't automatically parse JSON response bodies if content-type is wrong
retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@chrisbreiding chrisbreiding merged commit 700636a into feature-multidomain Jul 14, 2021
@chrisbreiding chrisbreiding deleted the issue-16773-multidomain-overrides branch April 5, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants