Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Update title method options type #17781

Merged
merged 1 commit into from
Aug 23, 2021
Merged

fix(types): Update title method options type #17781

merged 1 commit into from
Aug 23, 2021

Conversation

kotmatpockuh
Copy link
Contributor

@kotmatpockuh kotmatpockuh commented Aug 18, 2021 •
edited by jennifer-shehane
Loading

Add Timeoutable option to title method

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@kotmatpockuh
Update cypress.d.ts
c75e52a 
Add Timeoutable option to `title` method
@kotmatpockuh kotmatpockuh requested a review from a team as a code owner August 18, 2021 08:14
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 18, 2021

Thanks for taking the time to open a PR!

@kotmatpockuh kotmatpockuh requested review from jennifer-shehane and kuceb and removed request for a team August 18, 2021 08:14
@CLAassistant
Copy link

CLAassistant commented Aug 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kotmatpockuh kotmatpockuh mentioned this pull request Aug 18, 2021
Closed
@kotmatpockuh kotmatpockuh changed the title Update cypress.d.ts Update cypress.d.ts and update title options type Aug 18, 2021
@kotmatpockuh kotmatpockuh changed the title Update cypress.d.ts and update title options type Update title method options type Aug 18, 2021
@jennifer-shehane jennifer-shehane changed the title Update title method options type fix(types): Update title method options type Aug 23, 2021
@jennifer-shehane jennifer-shehane removed their request for review August 23, 2021 13:23
@chrisbreiding chrisbreiding merged commit 2a80c13 into cypress-io:develop Aug 23, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 27, 2021

Released in 8.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kuceb kuceb kuceb approved these changes

Assignees

@kotmatpockuh kotmatpockuh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title method type is wrong in cypress.d.ts
4 participants
@kotmatpockuh @CLAassistant @kuceb @chrisbreiding