Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run command queue in secondary domain and sync up command state between domains #17942

Merged
merged 8 commits into from
Sep 10, 2021

Conversation

chrisbreiding
Copy link
Contributor

User facing changelog

N/A - This is work for multidomain, targeting a feature branch

Additional details

Runs commands in the cy.switchToDomain callback in the secondary domain and displays them in the command log. Allows most commands to now be run in a secondary domain.

PR Tasks

  • Have tests been added/updated?
  • N/A Has the original issue or this PR been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@chrisbreiding chrisbreiding requested a review from a team as a code owner August 31, 2021 13:11
@chrisbreiding chrisbreiding requested review from jennifer-shehane and kuceb and removed request for a team August 31, 2021 13:11
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 31, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 31, 2021



Test summary

4184 2 63 1Flakiness 3


Run details

Project cypress
Status Failed
Commit 7d1e655
Started Sep 9, 2021 1:58 PM
Ended Sep 9, 2021 2:08 PM
Duration 10:40 💡
OS Linux Debian - 10.9
Browser Firefox 89

View run in Cypress Dashboard ➡️


Failures

e2e/focus_blur_spec.js Failed
1 intercept blur methods correctly > focus area
commands/actions/type_spec.js Failed
1 ... > element

Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
commands/xhr_spec.js Flakiness
1 src/cy/commands/xhr > abort > aborts xhrs currently in flight
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

packages/driver/src/cy/multidomain/index.ts Show resolved Hide resolved
@@ -1,4 +1,6 @@
import Bluebird from 'bluebird'
import * as $Log from '../../cypress/log'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bc of new esm changes this should be

Suggested change
import * as $Log from '../../cypress/log'
import $Log from '../../cypress/log'

causes an error at runtime in those tests that are skipped with this PR, is there any test that would catch this?
image

@chrisbreiding chrisbreiding requested a review from kuceb September 9, 2021 19:12
@chrisbreiding chrisbreiding merged commit 16ad6b4 into feature-multidomain Sep 10, 2021
@chrisbreiding chrisbreiding deleted the issue-16774-multidomain-run-queue branch April 5, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants