-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Run command queue in secondary domain and sync up command state between domains #17942
Merged
chrisbreiding
merged 8 commits into
feature-multidomain
from
issue-16774-multidomain-run-queue
Sep 10, 2021
Merged
chore: Run command queue in secondary domain and sync up command state between domains #17942
chrisbreiding
merged 8 commits into
feature-multidomain
from
issue-16774-multidomain-run-queue
Sep 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbreiding
requested review from
jennifer-shehane and
kuceb
and removed request for
a team
August 31, 2021 13:11
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
kuceb
suggested changes
Sep 9, 2021
@@ -1,4 +1,6 @@ | |||
import Bluebird from 'bluebird' | |||
import * as $Log from '../../cypress/log' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kuceb
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
N/A - This is work for multidomain, targeting a feature branch
Additional details
Runs commands in the
cy.switchToDomain
callback in the secondary domain and displays them in the command log. Allows most commands to now be run in a secondary domain.PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?