-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix initial installation on windows #18241
chore: fix initial installation on windows #18241
Conversation
Thanks for taking the time to open a PR!
|
As a reminder, do not use For example, reviewing the "scripts": {
"vite:dev": "vite",
"vite:build": "vite build",
"vite:preview": "yarn vite:build && vite preview"
} You're using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the need for npm/create-cypress-tests/scripts/copy-templates.js
. Can we use an existing library?
@@ -5,9 +5,10 @@ | |||
"private": false, | |||
"main": "index.js", | |||
"scripts": { | |||
"build": "yarn prepare-example && tsc -p ./tsconfig.json && node scripts/example copy-to ./dist/initial-template && yarn copy \"./src/**/*.template.js\" \"./dist/src\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, there has to be an easier way, right? Why is copy-templates
necessary? Will something like this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just try build the scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We spoke about this again, and we currently actually have no pattern within the build scripts for copying globbed files. (super weird). The other place we copy files within the scripts directory doesn't handle globs and isn't that pretty.
This fixes some windows development environments, so I think it's good to merge.
Context
After following the CONTRIBUTING.md guide, there are still errors running certain packages while developing in the Cypress repo on a Windows machine.
How to test
yarn
and install deps from the root directory of the project.Current Behavior
When running
yarn
from the root once installednode
andpython
there are errors.There are scripts running
yarn <node_modules/.bin/command> ...args
commands, and they will fail on windows since they resolve to<node_modules/.bin/command>
instead<node_modules/.bin/command.cmd>
.For example, on
npm/vue
we got this error:New Behavior
Tests
N/A