Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: throw when writing to 'read only' properties of config #18896

Merged
merged 88 commits into from
Dec 10, 2021
Merged

feat: throw when writing to 'read only' properties of config #18896

merged 88 commits into from
Dec 10, 2021

Commits on Oct 20, 2021

  1. add readonly prop

    @davidmunechika
    davidmunechika committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    65b3dd7 View commit details
    Browse the repository at this point in the history

  2. remove read only

    @davidmunechika
    davidmunechika committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    2e26506 View commit details
    Browse the repository at this point in the history

  3. verify config options

    @davidmunechika
    davidmunechika committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    8177afc View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. format

    @davidmunechika
    davidmunechika committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    531059c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. fix verify merge conflicts

    @davidmunechika
    davidmunechika committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    8c157e6 View commit details
    Browse the repository at this point in the history

  2. add retries property

    @davidmunechika
    davidmunechika committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    36269a0 View commit details
    Browse the repository at this point in the history

  3. add new properties

    @davidmunechika
    davidmunechika committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    65e91ae View commit details
    Browse the repository at this point in the history

  4. fix config override test

    @davidmunechika
    davidmunechika committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    b91e503 View commit details
    Browse the repository at this point in the history

  5. update writeable options

    @davidmunechika
    davidmunechika committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    464254e View commit details
    Browse the repository at this point in the history

  6. fix testConfigList

    @davidmunechika
    davidmunechika committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    f9beb27 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. fix request spec test

    @davidmunechika
    davidmunechika committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    53a9665 View commit details
    Browse the repository at this point in the history

  2. refactor validate into config package

    @davidmunechika
    davidmunechika committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    380cda8 View commit details
    Browse the repository at this point in the history

  3. fix isInteractive default

    @davidmunechika
    davidmunechika committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    7b27835 View commit details
    Browse the repository at this point in the history

  4. add config options

    @davidmunechika
    davidmunechika committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    b71fd60 View commit details
    Browse the repository at this point in the history

  5. fix keystroke validation

    @davidmunechika
    davidmunechika committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    0b35210 View commit details
    Browse the repository at this point in the history

  6. update snapshot

    @davidmunechika
    davidmunechika committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    3088a52 View commit details
    Browse the repository at this point in the history

  7. fix public config key snapshot

    @davidmunechika
    davidmunechika committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    0296226 View commit details
    Browse the repository at this point in the history

  8. add unit tests

    @davidmunechika
    davidmunechika committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    6014e5d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @davidmunechika
    davidmunechika authored Nov 15, 2021
    Configuration menu
    Copy the full SHA
    235b5b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @davidmunechika
    davidmunechika authored Nov 16, 2021
    Configuration menu
    Copy the full SHA
    e8dee2d View commit details
    Browse the repository at this point in the history

  2. testConfigList check

    @davidmunechika
    davidmunechika committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    75a4b09 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi… 

    …thub.com/cypress-io/cypress into issue-6407-warn-for-read-only-properties
    @davidmunechika
    davidmunechika committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    7e9743e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. fix test config overrides for .only

    @davidmunechika
    davidmunechika committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    404247d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. add tests

    @davidmunechika
    davidmunechika committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    19e9bed View commit details
    Browse the repository at this point in the history

  2. add test config override tests

    @davidmunechika
    davidmunechika committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    3f4063e View commit details
    Browse the repository at this point in the history

  3. fix config override test

    @davidmunechika
    davidmunechika committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    6c26a27 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. refactor error message

    @davidmunechika
    davidmunechika committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    ecf1fee View commit details
    Browse the repository at this point in the history

  2. fix unit tests

    @davidmunechika
    davidmunechika committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c37cd33 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @davidmunechika
    davidmunechika authored Nov 23, 2021
    Configuration menu
    Copy the full SHA
    0e7fb85 View commit details
    Browse the repository at this point in the history

  4. remove .only

    @davidmunechika
    davidmunechika committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    45b726d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi… 

    …thub.com/cypress-io/cypress into issue-6407-warn-for-read-only-properties
    @davidmunechika
    davidmunechika committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    982b320 View commit details
    Browse the repository at this point in the history

  6. fix fixtures spec message

    @davidmunechika
    davidmunechika committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    6e625c4 View commit details
    Browse the repository at this point in the history

  7. fix error handling

    @davidmunechika
    davidmunechika committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    d6568ee View commit details
    Browse the repository at this point in the history

  8. fix unit test

    @davidmunechika
    davidmunechika committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    ab97136 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @davidmunechika
    davidmunechika authored Nov 23, 2021
    Configuration menu
    Copy the full SHA
    25fbe7a View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. add description for isWriteable

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    2e74c1d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi… 

    …thub.com/cypress-io/cypress into issue-6407-warn-for-read-only-properties
    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    69175b8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @davidmunechika
    davidmunechika authored Nov 24, 2021
    Configuration menu
    Copy the full SHA
    d3b8898 View commit details
    Browse the repository at this point in the history

  4. remove .been

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    120fd49 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi… 

    …thub.com/cypress-io/cypress into issue-6407-warn-for-read-only-properties
    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    d3df4b8 View commit details
    Browse the repository at this point in the history

  6. remove read-only properties

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    e49178f View commit details
    Browse the repository at this point in the history

  7. remove exit property

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    f6332f4 View commit details
    Browse the repository at this point in the history

  8. skip validation for internal use

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    b24a0f1 View commit details
    Browse the repository at this point in the history

  9. update public config keys

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    e7ea235 View commit details
    Browse the repository at this point in the history

  10. fix config spec

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    7c350d7 View commit details
    Browse the repository at this point in the history

  11. add env check to config override test

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    e3986a6 View commit details
    Browse the repository at this point in the history

  12. convert array to object

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a56364a View commit details
    Browse the repository at this point in the history

  13. runtime config options not writeable

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a4e004a View commit details
    Browse the repository at this point in the history

  14. move error messages to errUtils

    @davidmunechika
    davidmunechika committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    0c8360e View commit details
    Browse the repository at this point in the history

  15. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @davidmunechika
    davidmunechika authored Nov 24, 2021
    Configuration menu
    Copy the full SHA
    ef210c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. remove isInteractive public option

    @davidmunechika
    davidmunechika committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    52e5cfb View commit details
    Browse the repository at this point in the history

  2. update snapshots

    @davidmunechika
    davidmunechika committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    019a4a3 View commit details
    Browse the repository at this point in the history

  3. update naming

    @davidmunechika
    davidmunechika committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    f644e25 View commit details
    Browse the repository at this point in the history

  4. update index naming

    @davidmunechika
    davidmunechika committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    7d80bbc View commit details
    Browse the repository at this point in the history

  5. update types

    @davidmunechika
    davidmunechika committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    9a9ff67 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. fix config spec

    @davidmunechika
    davidmunechika committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    905feef View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @davidmunechika
    davidmunechika authored Nov 29, 2021
    Configuration menu
    Copy the full SHA
    edd66e4 View commit details
    Browse the repository at this point in the history

  3. restore snapshots

    @davidmunechika
    davidmunechika committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    46ed7ec View commit details
    Browse the repository at this point in the history

  4. Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi… 

    …thub.com/cypress-io/cypress into issue-6407-warn-for-read-only-properties
    @davidmunechika
    davidmunechika committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    cecc6a4 View commit details
    Browse the repository at this point in the history

  5. make isInteractive internal

    @davidmunechika
    davidmunechika committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    6738f3e View commit details
    Browse the repository at this point in the history

  6. add runtime config option types

    @davidmunechika
    davidmunechika committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    138298d View commit details
    Browse the repository at this point in the history

  7. fix type failure

    @davidmunechika
    davidmunechika committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    a4626f5 View commit details
    Browse the repository at this point in the history

  8. add cypress internal env to system test

    @davidmunechika
    davidmunechika committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    b80340e View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. remove internal from isInteractive

    @davidmunechika
    davidmunechika committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    b4f7194 View commit details
    Browse the repository at this point in the history

  2. update types

    @davidmunechika
    davidmunechika committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    a9ab97a View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. only verify cypress config

    @davidmunechika
    davidmunechika committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    a7ea29d View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. pass cypress internal env in system test

    @davidmunechika
    davidmunechika committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    fedae31 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. move how env is passed in system tests

    @davidmunechika
    davidmunechika committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    1ddc0a0 View commit details
    Browse the repository at this point in the history

  2. use processEnv with error ui spec

    @davidmunechika
    davidmunechika committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    4a121fa View commit details
    Browse the repository at this point in the history

  3. use createIndex 

    Co-authored-by: Emily Rohrbough  <emilyrohrbough@users.noreply.github.com>
    @davidmunechika @emilyrohrbough
    davidmunechika and emilyrohrbough authored Dec 3, 2021
    Configuration menu
    Copy the full SHA
    bcfca89 View commit details
    Browse the repository at this point in the history

  4. fix logic for test config override options

    @davidmunechika
    davidmunechika committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    590eb0e View commit details
    Browse the repository at this point in the history

  5. fix logic for test config override options

    @davidmunechika
    davidmunechika committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    33d4db0 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @emilyrohrbough
    emilyrohrbough authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    2d9efd5 View commit details
    Browse the repository at this point in the history

  2. only check read only properties

    @davidmunechika
    davidmunechika committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    0c9c8dd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi… 

    …thub.com/cypress-io/cypress into issue-6407-warn-for-read-only-properties
    @davidmunechika
    davidmunechika committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    d20a59e View commit details
    Browse the repository at this point in the history

  4. add unit tests for non-cypress config

    @davidmunechika
    davidmunechika committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    101d445 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. use window.top instead of env

    @davidmunechika
    davidmunechika committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    875e287 View commit details
    Browse the repository at this point in the history

  2. fix runner tests

    @davidmunechika
    davidmunechika committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    3165ac0 View commit details
    Browse the repository at this point in the history

  3. update system tests

    @davidmunechika
    davidmunechika committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    6c8ea25 View commit details
    Browse the repository at this point in the history

  4. update error ui specs

    @davidmunechika
    davidmunechika committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    24ff38f View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. update snapshot text

    @davidmunechika
    davidmunechika committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    8a65255 View commit details
    Browse the repository at this point in the history

  2. fix error ui spec

    @davidmunechika
    davidmunechika committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    b4fd2ae View commit details
    Browse the repository at this point in the history

  3. add ts-ignore

    @davidmunechika
    davidmunechika committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    4f790a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. fix line numbers for system tests

    @davidmunechika
    davidmunechika committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    0c3b26e View commit details
    Browse the repository at this point in the history

  2. update snapshot

    @davidmunechika
    davidmunechika committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    31955ad View commit details
    Browse the repository at this point in the history

  3. update unit tests

    @davidmunechika
    davidmunechika committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    54e7548 View commit details
    Browse the repository at this point in the history

  4. fix snapshot spacing

    @davidmunechika
    davidmunechika committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    abfabc0 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Merge branch 'develop' into issue-6407-warn-for-read-only-properties

    @davidmunechika
    davidmunechika authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    de7b436 View commit details
    Browse the repository at this point in the history