chore: move `cy.type()` event tests to its own file. #20191

sainthkh · 2022-02-15T01:32:24Z

Next step of fix: cy.type(' ') fires click event on button-like elements. #20067
Related with this feedback

User facing changelog

N/A. It's just an internal cleanup.

Additional details

Why was this change necessary? => type_spec.js is too long. It takes about 2 minutes to finish. After adding event-related tests in this PR series, I thought it's a good idea to move them to its own file.
What is affected by this change? => N/A
Any implementation details to explain? => Simply moving tests.

How has the user experience changed?

N/A

PR Tasks

[na] Have tests been added/updated?
[na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?
[na] Have new configuration options been added to the cypress.schema.json?

cypress-bot · 2022-02-15T01:32:27Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

sainthkh

There are a few minor changes to the tests to make them consistent.

sainthkh · 2022-02-15T01:34:59Z

packages/driver/cypress/integration/commands/actions/type_events_spec.js

+        '#target-button-tag',
+        '#target-input-button',
+        '#target-input-image',
+        '#target-input-reset',
+        '#target-input-submit',


I added #target to make tests consistent with cy.type(' ') tests.

sainthkh · 2022-02-15T01:35:38Z

packages/driver/cypress/integration/commands/actions/type_events_spec.js

+        it(target, () => {
+          cy.get(target).focus().type('{enter}')
+
+          cy.get('li').should('have.length', 4)


This line has been added not to allow more than 4 lis.

sainthkh · 2022-02-15T01:35:59Z

packages/driver/cypress/integration/commands/actions/type_events_spec.js

+        it(target, () => {
+          cy.get(target).focus().type('{enter}')
+
+          cy.get('li').should('have.length', 3)


This line has been added not to allow more than 3 lis.

sainthkh · 2022-02-15T01:36:15Z

packages/driver/cypress/integration/commands/actions/type_events_spec.js

+        '#target-input-checkbox',
+        '#target-input-radio',


I added #target to make tests consistent with cy.type(' ') tests.

emilyrohrbough · 2022-02-15T15:16:55Z

packages/driver/cypress/integration/commands/actions/type_events_spec.js

+    it('fires events in the correct order')
+
+    it('fires events for each key stroke')


lets remove these empty tests or log an issue to back-fill these.

I tracked the history of type_spec.js and found out that it was like this long ago(d9bd8bf, link, it's a bit hard to track because type_spec became its own file from action_spec.).

IMHO, logging an issue and implementing these tests would be a better idea. But I'm not sure why it is left empty.

Sounds like a good idea. Mind logging the issue & add TODO with link to these?

I opened this issue at #20283.

emilyrohrbough · 2022-02-15T15:18:14Z

packages/driver/cypress/integration/commands/actions/type_events_spec.js

+    //   changed = 0
+
+    //   cy.$$(":text:first").change ->
+    //     changed += 1
+
+    //   cy.get(":text:first").invoke("val", "foo").type("b{tab}").then ->
+    //     expect(changed).to.eq 1


It is also like this long ago(d9bd8bf, link).

It looks like a valid test to me. IMHO, adding this to the issue above is a good idea.

emilyrohrbough · 2022-02-15T15:20:18Z

packages/driver/cypress/integration/commands/actions/type_events_spec.js

+    cy.visit('fixtures/dom.html')
+  })
+
+  describe('events', () => {


Would it be appropriate to rename this to keyboard events?

You're right. keyboard events better describes the tests. I fixed it that way.

sainthkh commented Feb 15, 2022

View reviewed changes

sainthkh force-pushed the issue-19541-part3 branch from 1ad4eb0 to f474883 Compare February 15, 2022 01:38

sainthkh marked this pull request as ready for review February 15, 2022 02:02

sainthkh requested a review from a team as a code owner February 15, 2022 02:02

sainthkh requested review from jennifer-shehane and removed request for a team February 15, 2022 02:02

emilyrohrbough reviewed Feb 15, 2022

View reviewed changes

sainthkh referenced this pull request Feb 16, 2022

extract driver action commands into separate files

d9bd8bf

sainthkh force-pushed the issue-19541-part3 branch from f474883 to 8239cdd Compare February 16, 2022 02:00

sainthkh added 2 commits February 21, 2022 09:32

chore: move tests to its own file.

52d7316

feedback

6622903

sainthkh force-pushed the issue-19541-part3 branch from 8239cdd to b186d44 Compare February 21, 2022 00:34

Add TODO comments

c944ac6

sainthkh force-pushed the issue-19541-part3 branch from b186d44 to c944ac6 Compare February 21, 2022 01:09

Merge branch 'develop' into issue-19541-part3

471c7a1

emilyrohrbough approved these changes Feb 22, 2022

View reviewed changes

flotwig requested a review from BlueWinds February 22, 2022 16:36

BlueWinds approved these changes Feb 24, 2022

View reviewed changes

BlueWinds merged commit 3d50292 into cypress-io:develop Feb 24, 2022

sainthkh mentioned this pull request Mar 8, 2022

fix: click event is fired correctly when focus has changed #20525

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move `cy.type()` event tests to its own file. #20191

chore: move `cy.type()` event tests to its own file. #20191

sainthkh commented Feb 15, 2022

cypress-bot bot commented Feb 15, 2022

sainthkh left a comment

sainthkh Feb 15, 2022

sainthkh Feb 15, 2022

sainthkh Feb 15, 2022

sainthkh Feb 15, 2022

emilyrohrbough Feb 15, 2022

sainthkh Feb 16, 2022 •

edited

Loading

emilyrohrbough Feb 16, 2022

sainthkh Feb 21, 2022

emilyrohrbough Feb 15, 2022

sainthkh Feb 16, 2022

emilyrohrbough Feb 15, 2022

sainthkh Feb 16, 2022

		it('fires events in the correct order')

		it('fires events for each key stroke')

chore: move cy.type() event tests to its own file. #20191

chore: move cy.type() event tests to its own file. #20191

Conversation

sainthkh commented Feb 15, 2022

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

cypress-bot bot commented Feb 15, 2022

sainthkh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sainthkh Feb 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chore: move `cy.type()` event tests to its own file. #20191

chore: move `cy.type()` event tests to its own file. #20191

sainthkh Feb 16, 2022 •

edited

Loading