Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing m1 installation issues for m1 macs #20345

Merged
merged 7 commits into from
Feb 23, 2022

Conversation

JessicaSachs
Copy link
Contributor

@JessicaSachs JessicaSachs commented Feb 23, 2022

Solution

Because download.js works fine since it uses arch() instead of os.arch() we should just update install.js to do the same thing for the beta channel.

This fix is unrelated to any of the rosetta issues or any native support for m1... it just brings Beta channel installation in parity with the prod builds.

Testing

I can test this locally once it's merged into 10.0-release, but ideally we can get this branch building the beta channel, but I'm not really sure how to set this up for random branches. @flotwig maybe?

I added a commit really quick to build and test this. I'll take it out after I test manually. Don't merge until then.

@JessicaSachs JessicaSachs requested a review from a team as a code owner February 23, 2022 21:17
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 23, 2022

Thanks for taking the time to open a PR!

@JessicaSachs JessicaSachs requested review from jennifer-shehane and removed request for a team February 23, 2022 21:17
@jennifer-shehane jennifer-shehane removed their request for review February 23, 2022 21:21
circle.yml Outdated
Comment on lines 31 to 32
- chore/beta-release-m1-support
- fix-darwin-win32-node-modules-install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JessicaSachs You'll want to leave the 10.0-release branch since this would erase those rules when it merges into 10.0-release. You'll want to replace anywhere that fix-darwin-win32-node-modules-install is written with this branch: chore/beta-release-m1-support

Copy link
Contributor Author

@JessicaSachs JessicaSachs Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reverting this change completely after i test.

I added a commit really quick to build and test this. I'll take it out after I test manually. Don't merge until then.

@cypress
Copy link

cypress bot commented Feb 23, 2022



Test summary

19278 0 218 0Flakiness 1


Run details

Project cypress
Status Passed
Commit df6c026
Started Feb 23, 2022 11:24 PM
Ended Feb 23, 2022 11:36 PM
Duration 11:31 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@JessicaSachs
Copy link
Contributor Author

I manually tested. Installing the beta build channel for m1 chips works now. In the future we should have an integration test with a real machine spun up by MacStadium, but I think that'll happen once we tackle the native Apple Silicone support.

@ImCesar ImCesar self-requested a review February 23, 2022 23:35
@JessicaSachs JessicaSachs merged commit 6ea3a8c into develop Feb 23, 2022
@JessicaSachs JessicaSachs deleted the chore/beta-release-m1-support branch February 23, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing beta channel builds on M1 chips is broken
4 participants