Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ExpectType assertions #20395

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Conversation

tgriesser
Copy link
Member

@tgriesser tgriesser commented Feb 28, 2022

Additional details

Several $ExpectType assertions contained a colon $ExpectType: which was silently ignoring the type assertion.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 28, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Feb 28, 2022



Test summary

19278 0 218 0Flakiness 3


Run details

Project cypress
Status Passed
Commit ae51be2
Started Feb 28, 2022 5:41 PM
Ended Feb 28, 2022 5:53 PM
Duration 12:08 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging_spec.ts Flakiness
1 ... > works with forceNetworkError

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tgriesser tgriesser marked this pull request as ready for review February 28, 2022 17:33
@tgriesser tgriesser requested a review from a team as a code owner February 28, 2022 17:33
@tgriesser tgriesser requested review from jennifer-shehane and removed request for a team February 28, 2022 17:33
@jennifer-shehane jennifer-shehane removed their request for review February 28, 2022 17:58
@tgriesser tgriesser merged commit f0f9786 into develop Feb 28, 2022
@tgriesser tgriesser deleted the tgriesser/chore/fix-type-assertions branch February 28, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants