fix: Prepare for Chrome's update for immutable document.domain #20405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and proxied requests that have domain injection
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
flotwig
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
@tbiethman Looks good, but I think that this change is user-facing and should be categorized as a fix:, we are now sending a new header that fixes an issue (even tho it's with an unreleased browser version)
tbiethman
changed the title
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Origin-Agent-Clusterheader for proxied responses to ensuredocument.domaincan continue to be set with Chrome v106 and upAdditional details
Chrome is planning to make document.domain immutable by default in a future release, currently targeted at v106. The will do so by interpreting the default value of the
Origin-Agent-Clusterresponse header astruerather thanfalseas it is today.This PR sets the
Origin-Agent-Clusterheader explicitly to false on the top-level runner response, as well as the iframe response and proxied request responses that have a domain setter injected into them. This will allow tests that utilize subdomains to continue to execute appropriately.Validation is a little tricky given that we're ahead of the game and no existing tests currently fail without this change. Unit tests/comments were added for the appropriate functions to ensure that these additions aren't inadvertently removed prior to the deprecation taking place. You can validate the current changes as well by starting the runner with Chromium 101 and verifying that no deprecation warnings are logged to the console during an e2e test run.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?