Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update release scripts to work with AWS SSO #20438

Merged
merged 13 commits into from
Mar 4, 2022
Merged

chore: update release scripts to work with AWS SSO #20438

merged 13 commits into from
Mar 4, 2022

Conversation

emilyrohrbough
Copy link
Member

  • Closes Update Release Process for SSO #20423

  • update release scripts to use AWS credentials API instead of use custom env var. This allows one to login via the aws cli and have the ability to run the move binaries and upload to s3 scripts.

  • updated CI env to use AWS envs instead of custom env var.

User facing changelog

n/a

How has the user experience changed?

One less ENV to set during the release and less work to determine the AWS session token and aligns with AWS docs for providing credentials.

PR Tasks

  • [n/a] Have tests been added/updated?
  • [n/a] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?
  • [n/a] Have new configuration options been added to the cypress.schema.json?

@emilyrohrbough emilyrohrbough requested a review from a team as a code owner March 1, 2022 22:11
@emilyrohrbough emilyrohrbough requested review from jennifer-shehane and removed request for a team March 1, 2022 22:11
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 1, 2022

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane removed their request for review March 1, 2022 22:19
@cypress
Copy link

cypress bot commented Mar 1, 2022 •
edited
Loading


Test summary

19278 • 0 • 218 • 0 • Flakiness 1

Run details
Project cypress
Status Passed
Commit f14f625
Started Mar 4, 2022 5:31 PM
Ended Mar 4, 2022 5:42 PM
Duration 11:35 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/cypress/proxy-logging_spec.ts 1 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane changed the title chores: update release scripts to work with AWS SSO chore: update release scripts to work with AWS SSO Mar 2, 2022
ryanthemanuel
ryanthemanuel reviewed Mar 2, 2022
View reviewed changes
guides/release-process.md Outdated

```shell
yarn move-binaries --sha <commit sha> --version <new target version>
```

8. Validate you are logged `npm` with `npm whoami`. Otherwise log in with `npm login`.

4. Publish the new npm package under the `dev` tag, using your personal npm account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbering needs to continue here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stopped since markdown would render the right numbers and this would caused the full doc to change 😬 I can update though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cypress-io/cypress@a3a1977 (#20438)

ryanthemanuel
ryanthemanuel reviewed Mar 2, 2022
View reviewed changes
scripts/binary/util/upload.js Outdated

return config
return await fromSSO({ profile: process.env.AWS_PROFILE || 'production' })()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Technically you don't need to await this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cypress-io/cypress@acba7f5 (#20438)

flotwig
flotwig previously approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @emilyrohrbough how have you been testing this? With DevSandbox?

@emilyrohrbough
Copy link
Member Author

emilyrohrbough commented Mar 4, 2022 •
edited
Loading

@flotwig Thanks! DevSandbox does not have a cdn.cypress.io bucket and none of the existing buckets in DevSandbox suggest we've uploaded binary content to it. This has been verified with CI and with partially running move-binary script to confirm we can access the S3 bucket with the credentials but no has been selected for moving content to the new directory.

@emilyrohrbough emilyrohrbough requested review from flotwig and ryanthemanuel and removed request for ryanthemanuel March 4, 2022 16:18
@emilyrohrbough emilyrohrbough merged commit ef3be70 into develop Mar 4, 2022
@emilyrohrbough emilyrohrbough deleted the fix-release-scripts branch March 4, 2022 18:31
@cypress-bot cypress-bot bot mentioned this pull request Mar 4, 2022
Closed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 14, 2022

Released in 9.5.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.5.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flotwig flotwig flotwig approved these changes

@ryanthemanuel ryanthemanuel ryanthemanuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Release Process for SSO
3 participants
@emilyrohrbough @flotwig @ryanthemanuel